|
| 1 | +import assert from "node:assert/strict" |
| 2 | +import { describe, it } from "node:test" |
| 3 | +import { IpcMessageType, IpcOrigin, TaskCommandName, ipcMessageSchema } from "@roo-code/types" |
| 4 | +import { IpcServer } from "../ipc-server.js" |
| 5 | + |
| 6 | +function fixture() { |
| 7 | + const logs: unknown[][] = [] |
| 8 | + const commands: unknown[] = [] |
| 9 | + const server = new IpcServer("/unused-test.sock", (...args) => logs.push(args)) |
| 10 | + server.on(IpcMessageType.TaskCommand, (clientId, command) => commands.push({ clientId, command })) |
| 11 | + return { logs, commands, receive: (data: unknown) => server["onMessage"](data) } |
| 12 | +} |
| 13 | +const key = "dummy-api-key-not-for-public-logging" |
| 14 | +const command = (requestId: string) => ({ |
| 15 | + type: IpcMessageType.TaskCommand, |
| 16 | + origin: IpcOrigin.Client, |
| 17 | + clientId: "client-1", |
| 18 | + data: { |
| 19 | + commandName: TaskCommandName.StartNewTask, |
| 20 | + data: { requestId, text: "private prompt", configuration: { apiProvider: "openai", openAiApiKey: key } }, |
| 21 | + }, |
| 22 | +}) |
| 23 | + |
| 24 | +describe("IPC rejection logging", () => { |
| 25 | + it("rejects an invalid request ID without logging its key, prompt or schema issue values", () => { |
| 26 | + const f = fixture() |
| 27 | + f.receive(command(`invalid request containing ${key}`)) |
| 28 | + assert.deepEqual(f.commands, []) |
| 29 | + assert.equal(f.logs.length, 1) |
| 30 | + assert.equal(f.logs[0]?.[0], "[server#onMessage] invalid payload") |
| 31 | + assert.ok(!JSON.stringify(f.logs).includes(key)) |
| 32 | + assert.ok(!JSON.stringify(f.logs).includes("private prompt")) |
| 33 | + assert.ok(!JSON.stringify(f.logs).includes("invalid request containing")) |
| 34 | + }) |
| 35 | + it("does not log credential-shaped primitive input or dynamic issue paths", () => { |
| 36 | + const f = fixture() |
| 37 | + const valid = command("valid-id") |
| 38 | + const malformedHeaders = { |
| 39 | + ...valid, |
| 40 | + data: { |
| 41 | + ...valid.data, |
| 42 | + data: { |
| 43 | + ...valid.data.data, |
| 44 | + configuration: { ...valid.data.data.configuration, openAiHeaders: { [key]: null } }, |
| 45 | + }, |
| 46 | + }, |
| 47 | + } |
| 48 | + const rejected = ipcMessageSchema.safeParse(malformedHeaders) |
| 49 | + assert.ok(!rejected.success) |
| 50 | + assert.ok(rejected.error.issues.some((issue) => issue.path.includes(key))) |
| 51 | + for (const data of [key, null, { type: key }, malformedHeaders]) { |
| 52 | + f.receive(data) |
| 53 | + } |
| 54 | + assert.equal(f.logs.length, 4) |
| 55 | + assert.ok(!JSON.stringify(f.logs).includes(key)) |
| 56 | + assert.deepEqual(f.commands, []) |
| 57 | + }) |
| 58 | + it("still dispatches a valid correlated command to its client without logging its settings", () => { |
| 59 | + const f = fixture() |
| 60 | + f.receive(command("valid-id")) |
| 61 | + assert.equal(f.commands.length, 1) |
| 62 | + assert.deepEqual(f.commands[0], { clientId: "client-1", command: command("valid-id").data }) |
| 63 | + assert.deepEqual(f.logs, []) |
| 64 | + }) |
| 65 | +}) |
0 commit comments