Skip to content

Commit f873a3d

Browse files
refactor(task): drop the unreachable return in persistTaskMetadata
Every path through the try/catch already reports this stage's result: false when the provider is gone, false from the catch, true after the history entry is written. The trailing return could never run, and it contradicted the contract the method now documents. No behaviour changes - which is also why no test moves when it comes back.
1 parent b2b3b0d commit f873a3d

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

‎src/core/task/Task.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1842,8 +1842,6 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
18421842
console.error("Failed to save task metadata:", error)
18431843
return false
18441844
}
1845-
1846-
return true
18471845
}
18481846

18491847
private findMessageByTimestamp(ts: number): ClineMessage | undefined {

0 commit comments

Comments
 (0)