Repository navigation
Commit f6af7d8
committed
fix(task): address CodeRabbit review on queued-message delivery
What: let direct (non-queued) submitUserMessage calls answer approval
asks as deny-with-feedback while keeping queued drains barred, and
treat a queue entry deleted mid-ack as a successful durable save.
Why: the drain guard was over-applied to direct submissions, so a
headless sendMessage during a command/use_mcp_server/tool approval ask
threw instead of delivering the user's denial, and a user deleting the
entry during the ack backoff made persistQueuedFeedbackAndAcknowledge
report failure after the feedback row was durably saved.
Impact: restores pre-drain direct-submission semantics; queued-message
invariants unchanged. Regression tests cover both paths.1 parent c7d0c44 commit f6af7d8
2 files changed
Lines changed: 72 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1186 | 1186 | | |
1187 | 1187 | | |
1188 | 1188 | | |
1189 | | - | |
| 1189 | + | |
| 1190 | + | |
| 1191 | + | |
| 1192 | + | |
| 1193 | + | |
1190 | 1194 | | |
1191 | 1195 | | |
1192 | 1196 | | |
| |||
2821 | 2825 | | |
2822 | 2826 | | |
2823 | 2827 | | |
2824 | | - | |
2825 | | - | |
| 2828 | + | |
2826 | 2829 | | |
2827 | 2830 | | |
| 2831 | + | |
| 2832 | + | |
| 2833 | + | |
| 2834 | + | |
| 2835 | + | |
2828 | 2836 | | |
2829 | 2837 | | |
2830 | | - | |
| 2838 | + | |
| 2839 | + | |
| 2840 | + | |
| 2841 | + | |
| 2842 | + | |
| 2843 | + | |
| 2844 | + | |
| 2845 | + | |
| 2846 | + | |
| 2847 | + | |
2831 | 2848 | | |
2832 | 2849 | | |
2833 | 2850 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
646 | 646 | | |
647 | 647 | | |
648 | 648 | | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
| 654 | + | |
| 655 | + | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
649 | 688 | | |
650 | 689 | | |
651 | 690 | | |
| |||
948 | 987 | | |
949 | 988 | | |
950 | 989 | | |
951 | | - | |
| 990 | + | |
952 | 991 | | |
953 | 992 | | |
954 | 993 | | |
955 | 994 | | |
956 | 995 | | |
957 | | - | |
| 996 | + | |
| 997 | + | |
| 998 | + | |
| 999 | + | |
| 1000 | + | |
| 1001 | + | |
| 1002 | + | |
| 1003 | + | |
| 1004 | + | |
| 1005 | + | |
958 | 1006 | | |
959 | | - | |
960 | 1007 | | |
961 | | - | |
| 1008 | + | |
962 | 1009 | | |
963 | 1010 | | |
964 | 1011 | | |
| |||
0 commit comments