Repository navigation
Commit f621443
committed
Address review: cover LM Studio early consumer termination
createMessage's finally block cancels the request-local SDK signal and
detaches the external abort listener, but no test pinned the early
consumer exit (break/return while the SDK stream is still pending):
the existing coverage only exercised normal completion and
external-signal aborts. New test consumes one chunk from a stream
that then stays pending, calls stream.return(), and asserts the
request-local SDK signal becomes aborted and the exact registered
external listener is removed (by reference, per the established
pattern). Negative control: removing the finally-block abort fails
exactly this test (isolated run).
Verification at this head: 27/27 green in lm-studio.spec.ts; tsc
--noEmit 0 errors; eslint --max-warnings=0 clean with suppression
counts unchanged; prettier clean.1 parent dc09b59 commit f621443
1 file changed
Lines changed: 30 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
446 | 446 | | |
447 | 447 | | |
448 | 448 | | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
449 | 479 | | |
450 | 480 | | |
451 | 481 | | |
| |||
0 commit comments