Skip to content

Commit f105a0b

Browse files
committed
perf(ci): memoize collaborator permission lookups in review-state workflow
1 parent cdc247d commit f105a0b

2 files changed

Lines changed: 30 additions & 1 deletion

File tree

‎.github/workflows/label-pr-review-state.yml‎

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,14 +316,24 @@ jobs:
316316
return match?.[1] ?? null;
317317
}
318318
319+
// Collaborator permissions are repository-level, so memoize them for
320+
// the whole run: a maintainer's current-head CHANGES_REQUESTED reaches
321+
// both review loops, and scheduled sweeps reconcile every open PR.
322+
const permissionCache = new Map();
319323
async function permissionFor(username) {
324+
const key = username.toLowerCase();
325+
if (permissionCache.has(key)) return permissionCache.get(key);
320326
try {
321327
const result = await github.rest.repos.getCollaboratorPermissionLevel({
322328
owner, repo, username,
323329
});
330+
permissionCache.set(key, result.data.permission);
324331
return result.data.permission;
325332
} catch (error) {
326-
if (error.status === 404) return 'none';
333+
if (error.status === 404) {
334+
permissionCache.set(key, 'none');
335+
return 'none';
336+
}
327337
throw error;
328338
}
329339
}

‎src/services/__tests__/pr-review-state-workflow.test.ts‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -425,6 +425,7 @@ async function runWorkflow(options: HarnessOptions = {}) {
425425
getPullRequest,
426426
listPullRequests: github.rest.pulls.list,
427427
listCommitStatusesForRef: github.rest.repos.listCommitStatusesForRef,
428+
permissionFor,
428429
}
429430
}
430431

@@ -2197,6 +2198,24 @@ describe("PR review-state workflow", () => {
21972198
expect(result.addLabels).toHaveBeenCalledWith(expect.objectContaining({ labels: ["awaiting-author"] }))
21982199
})
21992200

2201+
it("memoizes collaborator permission lookups across both review loops", async () => {
2202+
const result = await runWorkflow({
2203+
permissions: { maintainer: "write" },
2204+
reviews: [
2205+
coderabbitApproval,
2206+
{
2207+
login: "maintainer",
2208+
type: "User",
2209+
state: "CHANGES_REQUESTED",
2210+
submittedAt: REVIEWED_AT + 1_000,
2211+
},
2212+
],
2213+
})
2214+
2215+
expect(result.addLabels).toHaveBeenCalledWith(expect.objectContaining({ labels: ["awaiting-author"] }))
2216+
expect(result.permissionFor.mock.calls.filter(([args]) => args.username === "maintainer")).toHaveLength(1)
2217+
})
2218+
22002219
it("ignores blockers from non-collaborator reviewers", async () => {
22012220
const result = await runWorkflow({
22022221
reviews: [

0 commit comments

Comments
 (0)