Repository navigation
Commit ee68131
committed
fix(webview): resolve the command exit-status tooltip key
What: CommandExecution.tsx:200 called t("chat.commandExecution.exitStatus",
{ exitStatus }) — a dot-form key. i18next only splits a namespace on ":",
so it looks for a "chat.commandExecution.exitStatus" key inside the default
namespace, misses, and renders the raw key string in the tooltip. Changed to
t("chat:commandExecution.exitStatus", { exitCode }) and added a two-case
regression test.
Why: found while sweeping dead i18n keys. The AST pass correctly classified
the dot form as a non-reference, which made the underlying key look dead and
would have led to deleting a key that the UI needs. The key is live; the call
site was the bug. The interpolation variable also did not match the resource
("{{exitCode}}" vs the passed exitStatus), so even a resolved lookup would
have printed the literal placeholder.
Impact: the exit-status tooltip now shows "Exited with status 0" instead of
"chat.commandExecution.exitStatus". No other behaviour change.1 parent 2128f5e commit ee68131
2 files changed
Lines changed: 37 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
197 | 197 | | |
198 | 198 | | |
199 | 199 | | |
200 | | - | |
| 200 | + | |
201 | 201 | | |
202 | 202 | | |
203 | 203 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
| 9 | + | |
8 | 10 | | |
9 | 11 | | |
10 | 12 | | |
| |||
836 | 838 | | |
837 | 839 | | |
838 | 840 | | |
| 841 | + | |
| 842 | + | |
| 843 | + | |
| 844 | + | |
| 845 | + | |
| 846 | + | |
| 847 | + | |
| 848 | + | |
| 849 | + | |
| 850 | + | |
| 851 | + | |
| 852 | + | |
| 853 | + | |
| 854 | + | |
| 855 | + | |
| 856 | + | |
| 857 | + | |
| 858 | + | |
| 859 | + | |
| 860 | + | |
| 861 | + | |
| 862 | + | |
| 863 | + | |
| 864 | + | |
| 865 | + | |
| 866 | + | |
| 867 | + | |
| 868 | + | |
| 869 | + | |
| 870 | + | |
| 871 | + | |
| 872 | + | |
| 873 | + | |
| 874 | + | |
839 | 875 | | |
0 commit comments