Skip to content

Commit ee5e056

Browse files
committed
fix: address Fable 5.1 review feedback
1 parent 75d8c1e commit ee5e056

6 files changed

Lines changed: 41 additions & 4 deletions

File tree

‎packages/types/src/providers/bedrock.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ export const bedrockModels = {
253253
description: "Claude Opus 5 is Anthropic's most capable model for complex agentic coding and enterprise work.",
254254
},
255255
"anthropic.claude-fable-5-1": {
256-
maxTokens: 8192,
256+
maxTokens: 128_000,
257257
contextWindow: 1_000_000,
258258
supportsImages: true,
259259
supportsPromptCache: true,

‎packages/types/src/providers/vertex.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -490,7 +490,7 @@ export const vertexModels = {
490490
description: "Claude Opus 5 is Anthropic's most capable model for complex agentic coding and enterprise work.",
491491
},
492492
"claude-fable-5-1": {
493-
maxTokens: 8192,
493+
maxTokens: 128_000,
494494
contextWindow: 1_000_000,
495495
supportsImages: true,
496496
supportsPromptCache: true,

‎src/api/providers/__tests__/anthropic-vertex.spec.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1001,7 +1001,7 @@ describe("VertexHandler", () => {
10011001

10021002
const model = handler.getModel()
10031003
expect(model.id).toBe("claude-fable-5-1")
1004-
expect(model.info.maxTokens).toBe(8192)
1004+
expect(model.info.maxTokens).toBe(128_000)
10051005
expect(model.info.contextWindow).toBe(1_000_000)
10061006
expect(model.info.cacheReadsPrice).toBe(0.25)
10071007
expect(model.info.supportsReasoningBinary).toBe(true)

‎src/api/providers/__tests__/anthropic.spec.ts‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1040,6 +1040,30 @@ describe("AnthropicHandler", () => {
10401040
)
10411041
})
10421042

1043+
it.each([
1044+
["required", "required" as const],
1045+
["named", { type: "function" as const, function: { name: "get_weather" } }],
1046+
])("should normalize %s tool_choice to auto for Claude Fable 5.1", async (_, toolChoice) => {
1047+
const fableHandler = new AnthropicHandler({
1048+
apiKey: "test-api-key",
1049+
apiModelId: "claude-fable-5-1",
1050+
})
1051+
const stream = fableHandler.createMessage(systemPrompt, messages, {
1052+
taskId: "test-task",
1053+
tools: mockTools,
1054+
tool_choice: toolChoice,
1055+
})
1056+
1057+
await collectStream(stream)
1058+
1059+
expect(mockCreate).toHaveBeenCalledWith(
1060+
expect.objectContaining({
1061+
tool_choice: { type: "auto", disable_parallel_tool_use: false },
1062+
}),
1063+
expect.anything(),
1064+
)
1065+
})
1066+
10431067
it("should enable parallel tool calls when parallelToolCalls is true", async () => {
10441068
// Handler uses native protocol by default
10451069
const stream = handler.createMessage(systemPrompt, messages, {

‎src/api/providers/__tests__/bedrock.spec.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -839,6 +839,7 @@ describe("AwsBedrockHandler", () => {
839839

840840
const model = handler.getModel()
841841
expect(model.id).toBe("anthropic.claude-fable-5-1")
842+
expect(model.info.maxTokens).toBe(128_000)
842843
expect(model.info.contextWindow).toBe(1_000_000)
843844
expect(model.info.cacheReadsPrice).toBe(0.25)
844845
expect(model.info.minTokensPerCachePoint).toBe(512)

‎src/api/providers/anthropic.ts‎

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,21 @@ export class AnthropicHandler extends BaseProvider implements SingleCompletionHa
9393
betas.push("context-1m-2025-08-07")
9494
}
9595

96+
const convertedToolChoice = convertOpenAIToolChoiceToAnthropic(
97+
metadata?.tool_choice,
98+
metadata?.parallelToolCalls,
99+
)
100+
const toolChoice =
101+
modelId === "claude-fable-5-1" &&
102+
(convertedToolChoice?.type === "any" || convertedToolChoice?.type === "tool")
103+
? {
104+
type: "auto" as const,
105+
disable_parallel_tool_use: convertedToolChoice.disable_parallel_tool_use,
106+
}
107+
: convertedToolChoice
96108
const nativeToolParams = {
97109
tools: convertOpenAIToolsToAnthropic(metadata?.tools ?? []),
98-
tool_choice: convertOpenAIToolChoiceToAnthropic(metadata?.tool_choice, metadata?.parallelToolCalls),
110+
tool_choice: toolChoice,
99111
}
100112

101113
switch (modelId) {

0 commit comments

Comments
 (0)