Skip to content

Commit eca5982

Browse files
committed
test(task): cover cancelled tool-result flush
1 parent 0d80ec4 commit eca5982

1 file changed

Lines changed: 36 additions & 0 deletions

File tree

‎src/core/task/__tests__/Task.persistence.spec.ts‎

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -864,9 +864,40 @@ describe("Task persistence", () => {
864864
}
865865
})
866866

867+
it("does not wait or flush dependent tool results after abort", async () => {
868+
const task = new Task({
869+
provider: mockProvider,
870+
apiConfiguration: mockApiConfig,
871+
task: "test task",
872+
startTask: false,
873+
})
874+
task.abort = true
875+
task.userMessageContent = [{ type: "tool_result", tool_use_id: "tool-1", content: "done" }]
876+
const waitForPersistence = vi.spyOn(task, "waitForCurrentAssistantMessagePersistence")
877+
878+
await expect(task.flushPendingToolResultsToHistory()).resolves.toBe(false)
879+
expect(waitForPersistence).not.toHaveBeenCalled()
880+
expect(mockSaveApiMessages).not.toHaveBeenCalled()
881+
})
882+
883+
it("does not flush dependent tool results when the persistence barrier is cancelled", async () => {
884+
const task = new Task({
885+
provider: mockProvider,
886+
apiConfiguration: mockApiConfig,
887+
task: "test task",
888+
startTask: false,
889+
})
890+
task.userMessageContent = [{ type: "tool_result", tool_use_id: "tool-1", content: "done" }]
891+
vi.spyOn(task, "waitForCurrentAssistantMessagePersistence").mockResolvedValue(false)
892+
893+
await expect(task.flushPendingToolResultsToHistory()).resolves.toBe(false)
894+
expect(mockSaveApiMessages).not.toHaveBeenCalled()
895+
})
896+
867897
it("does not flush dependent tool results when assistant persistence retries are exhausted", async () => {
868898
vi.useFakeTimers()
869899
mockSaveApiMessages.mockRejectedValue(new Error("assistant write failed"))
900+
const consoleWarn = vi.spyOn(console, "warn").mockImplementation(() => undefined)
870901
const task = new Task({
871902
provider: mockProvider,
872903
apiConfiguration: mockApiConfig,
@@ -888,7 +919,12 @@ describe("Task persistence", () => {
888919
expect(mockSaveApiMessages).toHaveBeenCalledTimes(4)
889920
expect(task.assistantMessageSavedToHistory).toBe(false)
890921
expect(task.userMessageContent).toHaveLength(1)
922+
expect(consoleWarn).toHaveBeenCalledWith(
923+
expect.stringContaining("failed to persist assistant message"),
924+
expect.any(Error),
925+
)
891926
} finally {
927+
consoleWarn.mockRestore()
892928
mockSaveApiMessages.mockResolvedValue(undefined)
893929
vi.useRealTimers()
894930
}

0 commit comments

Comments
 (0)