@@ -47,6 +47,7 @@ describe("skillsMessageHandler", () => {
4747 const mockLog = vi . fn ( )
4848 const mockPostMessageToWebview = vi . fn ( )
4949 const mockGetSkillsMetadata = vi . fn ( )
50+ const mockGetSkillDiagnostics = vi . fn ( )
5051 const mockCreateSkill = vi . fn ( )
5152 const mockDeleteSkill = vi . fn ( )
5253 const mockMoveSkill = vi . fn ( )
@@ -57,6 +58,7 @@ describe("skillsMessageHandler", () => {
5758 const skillsManager = hasSkillsManager
5859 ? {
5960 getSkillsMetadata : mockGetSkillsMetadata ,
61+ getSkillDiagnostics : mockGetSkillDiagnostics ,
6062 createSkill : mockCreateSkill ,
6163 deleteSkill : mockDeleteSkill ,
6264 moveSkill : mockMoveSkill ,
@@ -90,6 +92,7 @@ describe("skillsMessageHandler", () => {
9092
9193 beforeEach ( ( ) => {
9294 vi . clearAllMocks ( )
95+ mockGetSkillDiagnostics . mockReturnValue ( [ ] )
9396 } )
9497
9598 describe ( "handleRequestSkills" , ( ) => {
@@ -100,7 +103,34 @@ describe("skillsMessageHandler", () => {
100103 const result = await handleRequestSkills ( provider )
101104
102105 expect ( result ) . toEqual ( mockSkills )
103- expect ( mockPostMessageToWebview ) . toHaveBeenCalledWith ( { type : "skills" , skills : mockSkills } )
106+ expect ( mockPostMessageToWebview ) . toHaveBeenCalledWith ( {
107+ type : "skills" ,
108+ skills : mockSkills ,
109+ skillDiagnostics : [ ] ,
110+ } )
111+ } )
112+
113+ it ( "sends structured malformed-skill diagnostics without hiding valid skills" , async ( ) => {
114+ const provider = createMockProvider ( true )
115+ const diagnostics = [
116+ {
117+ path : "/workspace/.roo/skills/broken/SKILL.md" ,
118+ source : "project" as const ,
119+ message : "bad indentation of a mapping entry" ,
120+ line : 3 ,
121+ column : 20 ,
122+ } ,
123+ ]
124+ mockGetSkillsMetadata . mockReturnValue ( mockSkills )
125+ mockGetSkillDiagnostics . mockReturnValue ( diagnostics )
126+
127+ await handleRequestSkills ( provider )
128+
129+ expect ( mockPostMessageToWebview ) . toHaveBeenCalledWith ( {
130+ type : "skills" ,
131+ skills : mockSkills ,
132+ skillDiagnostics : diagnostics ,
133+ } )
104134 } )
105135
106136 it ( "returns empty skills when skills manager is not available" , async ( ) => {
@@ -109,7 +139,11 @@ describe("skillsMessageHandler", () => {
109139 const result = await handleRequestSkills ( provider )
110140
111141 expect ( result ) . toEqual ( [ ] )
112- expect ( mockPostMessageToWebview ) . toHaveBeenCalledWith ( { type : "skills" , skills : [ ] } )
142+ expect ( mockPostMessageToWebview ) . toHaveBeenCalledWith ( {
143+ type : "skills" ,
144+ skills : [ ] ,
145+ skillDiagnostics : [ ] ,
146+ } )
113147 } )
114148
115149 it ( "handles errors and returns empty skills" , async ( ) => {
@@ -122,7 +156,11 @@ describe("skillsMessageHandler", () => {
122156
123157 expect ( result ) . toEqual ( [ ] )
124158 expect ( mockLog ) . toHaveBeenCalled ( )
125- expect ( mockPostMessageToWebview ) . toHaveBeenCalledWith ( { type : "skills" , skills : [ ] } )
159+ expect ( mockPostMessageToWebview ) . toHaveBeenCalledWith ( {
160+ type : "skills" ,
161+ skills : [ ] ,
162+ skillDiagnostics : [ ] ,
163+ } )
126164 } )
127165 } )
128166
@@ -142,7 +180,11 @@ describe("skillsMessageHandler", () => {
142180 expect ( result ) . toEqual ( mockSkills )
143181 expect ( mockCreateSkill ) . toHaveBeenCalledWith ( "new-skill" , "global" , "New skill description" , undefined )
144182 expect ( openFile ) . toHaveBeenCalledWith ( "/path/to/new-skill/SKILL.md" )
145- expect ( mockPostMessageToWebview ) . toHaveBeenCalledWith ( { type : "skills" , skills : mockSkills } )
183+ expect ( mockPostMessageToWebview ) . toHaveBeenCalledWith ( {
184+ type : "skills" ,
185+ skills : mockSkills ,
186+ skillDiagnostics : [ ] ,
187+ } )
146188 } )
147189
148190 it ( "creates a skill with mode restriction" , async ( ) => {
@@ -212,7 +254,11 @@ describe("skillsMessageHandler", () => {
212254
213255 expect ( result ) . toEqual ( [ mockSkills [ 1 ] ] )
214256 expect ( mockDeleteSkill ) . toHaveBeenCalledWith ( "test-skill" , "global" , undefined )
215- expect ( mockPostMessageToWebview ) . toHaveBeenCalledWith ( { type : "skills" , skills : [ mockSkills [ 1 ] ] } )
257+ expect ( mockPostMessageToWebview ) . toHaveBeenCalledWith ( {
258+ type : "skills" ,
259+ skills : [ mockSkills [ 1 ] ] ,
260+ skillDiagnostics : [ ] ,
261+ } )
216262 } )
217263
218264 it ( "deletes a skill with mode restriction" , async ( ) => {
@@ -280,7 +326,11 @@ describe("skillsMessageHandler", () => {
280326
281327 expect ( result ) . toEqual ( [ mockSkills [ 0 ] ] )
282328 expect ( mockMoveSkill ) . toHaveBeenCalledWith ( "test-skill" , "global" , undefined , "code" )
283- expect ( mockPostMessageToWebview ) . toHaveBeenCalledWith ( { type : "skills" , skills : [ mockSkills [ 0 ] ] } )
329+ expect ( mockPostMessageToWebview ) . toHaveBeenCalledWith ( {
330+ type : "skills" ,
331+ skills : [ mockSkills [ 0 ] ] ,
332+ skillDiagnostics : [ ] ,
333+ } )
284334 } )
285335
286336 it ( "moves a skill from one mode to another" , async ( ) => {
0 commit comments