@@ -521,6 +521,7 @@ vi.mock("../../config/ProviderSettingsManager", () => ({
521521 setModeConfig : vi . fn ( ) . mockResolvedValue ( undefined ) ,
522522 getModeConfigId : vi . fn ( ) . mockResolvedValue ( undefined ) ,
523523 resetAllConfigs : vi . fn ( ) . mockResolvedValue ( undefined ) ,
524+ deleteConfig : vi . fn ( ) . mockResolvedValue ( undefined ) ,
524525 }
525526 } ) ,
526527} ) )
@@ -1160,6 +1161,22 @@ describe("ClineProvider - Parallel Mode Support", () => {
11601161 await provider . dispose ( )
11611162 } )
11621163
1164+ it ( "should drop an unknown mode from setValues while keeping valid modes" , async ( ) => {
1165+ const provider = new ClineProvider ( mockContext , mockOutputChannel , "sidebar" , new ContextProxy ( mockContext ) )
1166+
1167+ await provider . setValues ( { mode : "not-a-real-mode" } )
1168+
1169+ expect ( provider . contextProxy . getValue ( "mode" ) ) . toBe ( "code" )
1170+ expect ( provider [ "viewLocalState" ] . mode ) . toBeUndefined ( )
1171+
1172+ await provider . setValues ( { mode : "architect" } )
1173+
1174+ expect ( provider . contextProxy . getValue ( "mode" ) ) . toBe ( "architect" )
1175+ expect ( provider [ "viewLocalState" ] . mode ) . toBe ( "architect" )
1176+
1177+ await provider . dispose ( )
1178+ } )
1179+
11631180 it ( "should sanitize raw viewStateId before using it as persisted viewStates key" , async ( ) => {
11641181 const provider = new ClineProvider ( mockContext , mockOutputChannel , "sidebar" , new ContextProxy ( mockContext ) )
11651182
@@ -1233,7 +1250,7 @@ describe("ClineProvider - Parallel Mode Support", () => {
12331250 // Simulate a concurrent writer (another view's provider) updating the shared
12341251 // map directly in storage, bypassing this proxy's cache.
12351252 const stored = ( await mockContext . globalState . get < Record < string , unknown > > ( "viewStates" ) ) ?? { }
1236- mockContext . globalState . update ( "viewStates" , {
1253+ await mockContext . globalState . update ( "viewStates" , {
12371254 ...stored ,
12381255 "view-b" : { mode : "debug" , updatedAt : 1 } ,
12391256 } )
@@ -1413,6 +1430,15 @@ describe("ClineProvider - Parallel Mode Support", () => {
14131430 currentApiConfigName : "deleted-profile" ,
14141431 apiConfiguration : { apiProvider : providerIdentifiers . anthropic } ,
14151432 }
1433+ vi . spyOn ( provider . providerSettingsManager , "listConfig" ) . mockResolvedValue ( [
1434+ { id : "replacement-id" , name : "replacement-profile" , apiProvider : providerIdentifiers . openrouter } ,
1435+ ] )
1436+ vi . spyOn ( provider . providerSettingsManager , "activateProfile" ) . mockResolvedValue ( {
1437+ name : "replacement-profile" ,
1438+ id : "replacement-id" ,
1439+ apiProvider : providerIdentifiers . openrouter ,
1440+ openRouterApiKey : "replacement-key" ,
1441+ } as unknown as Awaited < ReturnType < typeof provider . providerSettingsManager . getProfile > > )
14161442
14171443 await provider . deleteProviderProfile ( {
14181444 id : "deleted-id" ,
@@ -1425,6 +1451,13 @@ describe("ClineProvider - Parallel Mode Support", () => {
14251451 expect ( state . listApiConfigMeta ) . toEqual ( [
14261452 { id : "replacement-id" , name : "replacement-profile" , apiProvider : providerIdentifiers . openrouter } ,
14271453 ] )
1454+ // The view-local buffer must hold the replacement profile's settings rather
1455+ // than the deleted profile's.
1456+ expect ( provider [ "viewLocalState" ] . apiConfiguration ) . toEqual ( {
1457+ apiProvider : providerIdentifiers . openrouter ,
1458+ openRouterApiKey : "replacement-key" ,
1459+ } )
1460+ expect ( vi . mocked ( provider . providerSettingsManager . deleteConfig ) ) . toHaveBeenCalledWith ( "deleted-profile" )
14281461
14291462 await provider . dispose ( )
14301463 } )
@@ -1437,7 +1470,7 @@ describe("ClineProvider - Parallel Mode Support", () => {
14371470 { id : "doomed-id" , name : "doomed-profile" , apiProvider : providerIdentifiers . openrouter } ,
14381471 ] )
14391472 // Two views have durable pins; one pins the profile about to be deleted.
1440- mockContext . globalState . update ( "viewStates" , {
1473+ await mockContext . globalState . update ( "viewStates" , {
14411474 "view-keeps" : { mode : "code" , currentApiConfigName : "keeper-profile" , updatedAt : 1 } ,
14421475 "view-deleted" : { mode : "architect" , currentApiConfigName : "doomed-profile" , updatedAt : 2 } ,
14431476 } )
0 commit comments