Repository navigation
Commit e943530
authored
feat(ui): add time and date format settings and message timestamps (#2223)
* feat(ui): add time and date format settings and message timestamps
* fix(ui): address review feedback on time and date settings
* test(visual): add Language tab baselines
* test(e2e): mask the message time in the extension host visual test
* test(e2e): update the chat sidebar baseline for the message time
* test(e2e): give the masked message time a fixed width so the mask box is stable
* test(e2e): iterate the message times with forEach (no DOM.Iterable in this tsconfig)
* test(e2e): regenerate the chat sidebar baseline from CI with a fixed-width message time
* feat(ui): make the time format a real radio group with roving focus and arrow keys
* test(host): cover saving the date and time settings and returning them to the webview
* test(ui): cover the date format on older messages across user, assistant and completion rows
* test(e2e): pin the masked message time to one fixed-size line, and update the baseline
* refactor(ui): drop the unused formatDate; no tooltip that repeats an absolute time
* fix(ui): select the time format option that receives focus; keep keyboard behaviour assertions in Vitest
* test: assert the webview state refresh after a save; cover the date format in another display language
* test(ui): cover the task header time and the display language fallback
* fix(ui): save the three date and time settings all-or-nothing
* test(ui): cover the message time while editing, and an invalid task time in the header
* fix(ui): unwind overlapping failed saves in any order, keep imports, follow the existing error path for other keys, honest failure text
* fix(import): restore display settings if settings import write fails
* fix(import): wait for every display write before restoring
* fix(import): say which display settings could not be restored
* refactor: one write chain for saves and imports of the display settings
* fix: validate display values, order writes per key down to storage, read what a write replaces when it starts
* test: cover the handed-over previous value of a queued write
* fix: keep a store made outside a save when a failed write is rolled back
* fix: count only stores by others, and re-read a handed-over value if someone stored the key before the write started
* fix: a finished write is the base of a later queued one; no empty block for an invalid timestamp
* test: cover a write that had started when the earlier one finished
* fix(import): keep the display writes active until every step has succeeded; baseline a handed-over value at the store that held it
* fix: hand a rolled-back value on only while nobody else stored the key; test omitted display keys from non-default values
* fix: count only stores by others directly, marking the store being issued here
* fix: a rejected outside store of a tracked setting is not a store to protect
* fix: number the stores by others, so a rejected one cancels only itself
* fix: keep the stores by others only while a write of the key is pending
* fix: keep recording stores by others while the restore of an undone write waits in the queue
* test: two restores waiting for one key
* refactor: one helper for the count of waiting restores
* fix: put the cache back when a store of a tracked setting is rejected
* fix: validate the display language on the host; fall back to English for an unusable locale; reconcile the cache from storage when a tracked store is rejected
* fix: re-stamp the earlier write only if nobody else stored the key; the bookkeeping hook covers every map
* test: an empty experiments or customSupportPrompts value in a display-settings save
* refactor: drop the rollback logic for the display settings; keep host-side validation of the values
* fix: the public API writes check the display settings like updateSettings
* test: document the partial-failure behaviour of the display settings save; Playwright stories for the timestamp rows, task header and absolute history time
* test: fix the timestamp stories: the footer date format, and a focus target only where there is a control
* test: Linux baselines for the timestamp rows, the expanded task header and the absolute history time, in four themes
* ci: rerun the visual check (the welcome contrast check sampled a fade in progress; it passed on the run before)
* test: the partial-save contract of the public API path; tooltip and future-day coverage for the message time
* feat: ContextProxy.setValues reads the cache back for failed keys and reports which keys were stored and which were not
* fix: setValues reads a failed secret back from the secret storage too
* test: cover the report wording and the pass-through key in ContextProxy.setValues
* fix: SettingsWriteError.cause overrides Error.cause
* fix: a failed store reads its key back into the cache for every setting and for secrets, guarded against newer writes; the first failure stays the cause
* fix: the secret read-back has a deadline so the write error reaches the caller; the cache read-back is documented and tested as best effort for global state
* test: a failed secret store that a newer write has superseded is not read back
* fix: ContextProxy releases the write owner when a write is over and handles storage that throws at once; tests for secret deletion, the error name and owner release
* fix: refreshSecrets takes over a key from a pending write, so a failed write's read-back cannot hide the loaded secret
* fix: refreshSecrets detects a write that started and finished during its read (per-key write count); the race test holds back the right key
* feat: a save that changes a time or date setting waits for the host's answer (settingsSaveResult) and keeps the edit unsaved after a failure
* chore: knip does not count the webview test helpers as unused files1 parent 1c15695 commit e943530
77 files changed
Lines changed: 3854 additions & 76 deletions
File tree
- apps/vscode-e2e/src/visual
- __screenshots__
- packages/types/src
- src
- core
- config
- __tests__
- webview
- __tests__
- extension
- __tests__
- webview-ui
- playwright/gallery
- src
- __tests__
- components
- chat
- __tests__
- __screenshots__
- history
- __tests__
- settings
- __tests__
- __screenshots__
- context
- i18n/locales
- ca
- de
- en
- es
- fr
- hi
- id
- it
- ja
- ko
- nl
- pl
- pt-BR
- ru
- tr
- vi
- zh-CN
- zh-TW
- utils
- __tests__
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
92 | 105 | | |
93 | | - | |
| 106 | + | |
94 | 107 | | |
95 | 108 | | |
96 | 109 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| 50 | + | |
50 | 51 | | |
51 | 52 | | |
52 | 53 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
280 | 280 | | |
281 | 281 | | |
282 | 282 | | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
283 | 298 | | |
284 | 299 | | |
285 | 300 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
| 53 | + | |
53 | 54 | | |
54 | 55 | | |
55 | 56 | | |
| |||
341 | 342 | | |
342 | 343 | | |
343 | 344 | | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
344 | 348 | | |
345 | 349 | | |
346 | 350 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
33 | 64 | | |
34 | 65 | | |
35 | 66 | | |
| |||
360 | 391 | | |
361 | 392 | | |
362 | 393 | | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
363 | 403 | | |
364 | 404 | | |
365 | 405 | | |
366 | 406 | | |
367 | 407 | | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
368 | 416 | | |
369 | | - | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
370 | 430 | | |
371 | 431 | | |
372 | 432 | | |
| |||
384 | 444 | | |
385 | 445 | | |
386 | 446 | | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
387 | 450 | | |
388 | 451 | | |
389 | | - | |
390 | | - | |
391 | | - | |
392 | | - | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
393 | 495 | | |
394 | 496 | | |
395 | 497 | | |
| |||
400 | 502 | | |
401 | 503 | | |
402 | 504 | | |
403 | | - | |
| 505 | + | |
404 | 506 | | |
405 | 507 | | |
406 | 508 | | |
| |||
409 | 511 | | |
410 | 512 | | |
411 | 513 | | |
412 | | - | |
| 514 | + | |
413 | 515 | | |
414 | 516 | | |
415 | 517 | | |
| |||
555 | 657 | | |
556 | 658 | | |
557 | 659 | | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
558 | 668 | | |
559 | 669 | | |
560 | | - | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
561 | 690 | | |
562 | 691 | | |
563 | 692 | | |
| |||
0 commit comments