You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit e4b102b
Browse filesBrowse the repository at this point in the historyBrowse files
test(activate): assert the stranded creation settles instead of leaving it parked
The row on this file flagged a leak, and the finally did already fix the override it named.
It did not fix the other half. All three gates sit inside the try, so a failing assertion or a
waitFor timeout leaves a gate parked, the creation awaiting it never settles, and
registerCommands.ts clears apiTabPanelCreation only when that creation settles (:448-451) while
the reuse paths keep awaiting that chain (:529-530, guard at :601-602) - so one stranded
creation occupies the queue for the rest of the file.
Each gate now carries a release count, the finally releases any gate the test did not already
let go, both creations are marked rejection-handled at creation so a failure here cannot surface
as an unhandled rejection in the next test, and the drain is awaited in the finally: were a gate
still parked, that await would not return and this file would report the timeout instead of the
next test breaking. The green path asserts the terminal states directly: three gates released
once, the API creation rejected by the lock failure, the ordinary creation fulfilling with its
own provider.
Controls under node 22.23.4 (the .nvmrc pin; PATH carries v25.9.0): with the release loop
removed and the park condition tampered, the knock-on the row described reproduces - this test
and 23 later tests in the file each print Test timed out in 20000ms; with the release loop
present the same tamper fails only this test with "condition never held" (1 failed | 81 passed);
swapping the expected outcome pair fails with an AssertionError naming the two statuses.
Untampered: 82 passed (82) three consecutive runs, tsc --noEmit -p tsconfig.json exit 0,
prettier --check clean, eslint --max-warnings=0 exit 0 with src/eslint-suppressions.json
byte-identically restored at 30,910 B and its count unchanged. Test-only: src/activate/
registerCommands.ts stays blob ac81bfa.
0 commit comments