You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit e3d2460
Browse filesBrowse the repository at this point in the historyBrowse files
fix(activate): resolve manifest rows before reading them
The commandManifest spec read `row.when` right after a `toBeDefined` assertion. `Array.prototype.find`
answers `T | undefined` and no vitest matcher narrows it back, so the reads at
src/activate/__tests__/commandManifest.spec.ts:36,42,48,56 and 80 failed the hosted `pnpm run
check-types` (tsc --noEmit in src) with five TS18048 errors and turned the compile context red.
`resolved()` returns the row or throws with that row's own message, so the lookups stay non-optional
without a cast and a dropped row still fails with the message it carried before.
Gates (pinned node v22.23.4, worktree at this commit): tsc --noEmit in src exit 0 (was exit 2 with
the five errors); eslint --max-warnings=0 and prettier --check on the file exit 0; vitest misc lane
on the file 21 passed before and after; mutating the editor/title row -> 4 failed/17 passed, flipping
its when clause -> 1 failed/20 passed, renaming the declaration -> 2 failed/19 passed.
0 commit comments