Skip to content

Commit e22fcbf

Browse files
committed
fix(lint): cover provider declarations
1 parent 938cbe5 commit e22fcbf

3 files changed

Lines changed: 20 additions & 0 deletions

File tree

‎src/__tests__/no-raw-provider-identifiers.spec.mjs‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,19 @@ describe("no-raw-provider-identifiers", () => {
3636
expect(messages).toHaveLength(2)
3737
})
3838

39+
it("rejects canonical literals in provider-like variable declarations", () => {
40+
const messages = lint(`
41+
const apiProvider = "poe"
42+
let fallbackProvider = \`openrouter\`
43+
const label = "poe"
44+
`)
45+
46+
expect(messages.map(({ message }) => message)).toEqual([
47+
'Use providerIdentifiers.poe instead of the raw provider identifier "poe".',
48+
'Use providerIdentifiers.openrouter instead of the raw provider identifier "openrouter".',
49+
])
50+
})
51+
3952
it("rejects canonical literals in provider-like assignments and comparisons", () => {
4053
const messages = lint(`
4154
config["apiProvider"] = "poe"

‎src/eslint-rules/no-raw-provider-identifiers.mjs‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,11 @@ export const noRawProviderIdentifiers = {
6767
reportIfRawProvider(node.value)
6868
}
6969
},
70+
VariableDeclarator(node) {
71+
if (isProviderLike(node.id)) {
72+
reportIfRawProvider(node.init)
73+
}
74+
},
7075
AssignmentExpression(node) {
7176
if (isProviderLike(node.left)) {
7277
reportIfRawProvider(node.right)

‎src/eslint.config.mjs‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,9 @@ export default [
3939
"**/__tests__/**",
4040
"**/__mocks__/**",
4141
"**/*.spec.ts",
42+
"**/*.spec.tsx",
4243
"**/*.test.ts",
44+
"**/*.test.tsx",
4345
"**/fixtures/**",
4446
// Embedding providers are a separate domain whose identifiers only partially
4547
// overlap with the canonical API provider registry.

0 commit comments

Comments
 (0)