Repository navigation
Commit e12e961
committed
test(settings): name perWriteCheckpoints in the checkpoint payload assertions
The checkpoint and terminal payload assertions used objectContaining, which cannot
fail when a key is missing from the updateSettings payload at all: dropping
perWriteCheckpoints from the payload leaves every existing case green. The
fallback-defaults case now names the key, and a new case loads a stored true,
un-checks the box, and saves, so the payload has to carry the false the user chose
rather than the display default.
Test-only: SettingsView.tsx is untouched. On the shipped payload line, removing the
key fails both assertions, and replacing the value with the default constant fails
only the new case. The LogicalOperator mutant the mutation CI drew at :418
(?? changed to &&) leaves the suite green, because the webview state default means
the left operand is never undefined at submit, so that mutant is equivalent here.
Answering the codeRabbit thread on webview-ui/src/components/settings/SettingsView.tsx:418 (#1406).1 parent 6bc14e7 commit e12e961
1 file changed
Lines changed: 36 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
8 | 12 | | |
9 | 13 | | |
10 | 14 | | |
| |||
527 | 531 | | |
528 | 532 | | |
529 | 533 | | |
| 534 | + | |
530 | 535 | | |
531 | 536 | | |
532 | 537 | | |
533 | 538 | | |
534 | 539 | | |
535 | 540 | | |
536 | 541 | | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
537 | 572 | | |
538 | 573 | | |
539 | 574 | | |
| |||
0 commit comments