|
| 1 | +import path from "node:path" |
| 2 | + |
1 | 3 | import { type ProviderSettings, RooCodeEventName } from "@roo-code/types" |
2 | 4 |
|
3 | 5 | import { Task } from "../Task" |
@@ -107,26 +109,41 @@ describe("Task dispose method", () => { |
107 | 109 | resolveTaskDirectory!("/test/path/tasks/test-task") |
108 | 110 | await disposal |
109 | 111 |
|
110 | | - expect(OutputInterceptor.cleanup).toHaveBeenCalledWith("/test/path/tasks/test-task/command-output") |
| 112 | + expect(OutputInterceptor.cleanup).toHaveBeenCalledWith( |
| 113 | + path.join("/test/path/tasks/test-task", "command-output"), |
| 114 | + ) |
111 | 115 | expect(disposalComplete).toBe(true) |
112 | 116 | }) |
113 | 117 |
|
| 118 | + test("should report command output cleanup failures before disposal completes", async () => { |
| 119 | + const cleanupError = new Error("cleanup failed") |
| 120 | + const consoleErrorSpy = vi.spyOn(console, "error").mockImplementation(() => {}) |
| 121 | + vi.mocked(getTaskDirectoryPath).mockRejectedValueOnce(cleanupError) |
| 122 | + |
| 123 | + await task.dispose() |
| 124 | + |
| 125 | + expect(consoleErrorSpy).toHaveBeenCalledWith("Error cleaning up command output artifacts:", cleanupError) |
| 126 | + consoleErrorSpy.mockRestore() |
| 127 | + }) |
| 128 | + |
114 | 129 | test("should expose completion of deferred diff reversion", async () => { |
115 | 130 | let resolveReversion: () => void |
116 | 131 | const reversion = new Promise<void>((resolve) => { |
117 | 132 | resolveReversion = resolve |
118 | 133 | }) |
119 | 134 | task.isStreaming = true |
120 | 135 | task.diffViewProvider.isEditing = true |
121 | | - vi.spyOn(task.diffViewProvider, "revertChanges").mockReturnValue(reversion) |
| 136 | + const revertChangesSpy = vi.spyOn(task.diffViewProvider, "revertChanges").mockReturnValue(reversion) |
122 | 137 |
|
123 | 138 | const disposal = task.dispose() |
| 139 | + await vi.waitFor(() => expect(OutputInterceptor.cleanup).toHaveBeenCalled()) |
124 | 140 | let disposalComplete = false |
125 | 141 | void disposal.then(() => { |
126 | 142 | disposalComplete = true |
127 | 143 | }) |
128 | 144 | await Promise.resolve() |
129 | 145 | expect(disposalComplete).toBe(false) |
| 146 | + expect(revertChangesSpy).toHaveBeenCalledOnce() |
130 | 147 |
|
131 | 148 | resolveReversion!() |
132 | 149 | await disposal |
|
0 commit comments