Repository navigation
Commit d0496c5
committed
fix(core): answer the review nits on the observation registry unit
- observationRegistry.spec.ts: restore real timers from an afterEach on the
describe block, so a failing assertion in the fake-timer test cannot leave the
rest of the file running on fake timers.
- Task.dispose.test.ts: await the second Task's disposal in the finally block
instead of firing it and forgetting it, so teardown is deterministic and a
rejection surfaces.
- Task.ts: describe cancellationGeneration in repository terms. The run-state
kernel has no transition that clears latches.abort, so abort stays true across
resumeAfterDelegation() and only the counter keeps a cancelled run apart from
the resumed one; the guarded write the comment documents has no production
reader yet, so the comment no longer claims a comparison that does not happen.
The production change is comment-only: the mutation gate still prices 25 counted
executable lines and 15 selectors for this unit.1 parent b9b85de commit d0496c5
3 files changed
Lines changed: 24 additions & 21 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
397 | 397 | | |
398 | 398 | | |
399 | 399 | | |
400 | | - | |
401 | | - | |
402 | | - | |
403 | | - | |
404 | | - | |
405 | | - | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
406 | 408 | | |
407 | 409 | | |
408 | 410 | | |
| |||
3607 | 3609 | | |
3608 | 3610 | | |
3609 | 3611 | | |
3610 | | - | |
3611 | | - | |
3612 | | - | |
3613 | | - | |
3614 | | - | |
3615 | | - | |
3616 | | - | |
| 3612 | + | |
| 3613 | + | |
| 3614 | + | |
| 3615 | + | |
| 3616 | + | |
| 3617 | + | |
3617 | 3618 | | |
3618 | 3619 | | |
3619 | 3620 | | |
| |||
3624 | 3625 | | |
3625 | 3626 | | |
3626 | 3627 | | |
3627 | | - | |
| 3628 | + | |
3628 | 3629 | | |
3629 | | - | |
3630 | | - | |
| 3630 | + | |
| 3631 | + | |
3631 | 3632 | | |
3632 | 3633 | | |
3633 | 3634 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
122 | | - | |
| 122 | + | |
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
| |||
142 | 142 | | |
143 | 143 | | |
144 | 144 | | |
145 | | - | |
| 145 | + | |
146 | 146 | | |
147 | 147 | | |
148 | 148 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
6 | 10 | | |
7 | 11 | | |
8 | 12 | | |
| |||
25 | 29 | | |
26 | 30 | | |
27 | 31 | | |
28 | | - | |
29 | | - | |
30 | 32 | | |
31 | 33 | | |
32 | 34 | | |
| |||
0 commit comments