Repository navigation
Commit cfbf79c
committed
fix(file-safety): make the DACL steps best-effort as #2016 states
The tracking issue's acceptance line says the Windows DACL is saved and restored best-effort and reported through onWarning when it cannot be done; the unit refused instead, which is what keeps review thread 4402625496 open. The save and inspect refusals and the post-commit restore throw become warnings that name the target and the failure, the dump is still kept for a manual icacls /restore, and the two DACL error classes leave with the throws that carried them. The specs follow the contract rather than the classes, and the real-filesystem case now tolerates the kept dump instead of failing on a machine where icacls /restore cannot write into a temp directory.1 parent f0a80ce commit cfbf79c
3 files changed
Lines changed: 158 additions & 199 deletions
File tree
- src/services/file-safety
- __tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
36 | 34 | | |
37 | 35 | | |
38 | 36 | | |
39 | | - | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
40 | 41 | | |
41 | 42 | | |
42 | 43 | | |
| |||
0 commit comments