Skip to content

Commit ce8aa6d

Browse files
author
daewoongoh
committed
test: cover ModelSelector display name rendering and search
1 parent 21d363b commit ce8aa6d

1 file changed

Lines changed: 59 additions & 0 deletions

File tree

‎webview-ui/src/components/chat/__tests__/ModelSelector.spec.tsx‎

Lines changed: 59 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,19 @@ vi.mock("@/components/settings/utils/providerModelConfig", async (importOriginal
5252
}
5353
})
5454

55+
const selectedModelOverride = vi.hoisted(() => ({
56+
value: undefined as { id: string; info?: { displayName?: string } } | undefined,
57+
}))
58+
59+
vi.mock("@/components/ui/hooks/useSelectedModel", async (importOriginal) => {
60+
const actual = await importOriginal<typeof import("@/components/ui/hooks/useSelectedModel")>()
61+
return {
62+
...actual,
63+
useSelectedModel: (...args: Parameters<typeof actual.useSelectedModel>) =>
64+
selectedModelOverride.value ?? actual.useSelectedModel(...args),
65+
}
66+
})
67+
5568
import { vscode } from "@/utils/vscode"
5669

5770
const base = { contextWindow: 1000, supportsPromptCache: false }
@@ -65,6 +78,7 @@ describe("ModelSelector", () => {
6578
beforeEach(() => {
6679
vi.clearAllMocks()
6780
staticModelsOverride.value = undefined
81+
selectedModelOverride.value = undefined
6882
routerModelsResult.value = { data: undefined, isLoading: false }
6983
routerModelsResult.calls = []
7084
extensionState.organizationAllowList = { allowAll: true, providers: {} }
@@ -155,6 +169,51 @@ describe("ModelSelector", () => {
155169
expect(Object.values(patch)).not.toContain("")
156170
})
157171

172+
describe("display names", () => {
173+
const named = {
174+
"model-a": { ...base, displayName: "Alpha Fast" },
175+
"model-b": { ...base, displayName: "Beta Deep" },
176+
}
177+
178+
test("shows the selected model's display name instead of its id on the trigger", () => {
179+
selectedModelOverride.value = { id: "model-a", info: { displayName: "Alpha Fast" } }
180+
181+
render(<ModelSelector apiConfiguration={anthropicConfig} title="Select model" />)
182+
183+
const trigger = screen.getByTestId("model-selector-trigger")
184+
expect(trigger).toHaveTextContent("Alpha Fast")
185+
expect(trigger).not.toHaveTextContent("model-a")
186+
})
187+
188+
test("lists display names and finds a model by searching its display name", () => {
189+
staticModelsOverride.value = {
190+
...named,
191+
"model-c": { ...base, displayName: "Gamma" },
192+
"model-d": { ...base, displayName: "Delta" },
193+
"model-e": { ...base, displayName: "Epsilon" },
194+
"model-f": { ...base, displayName: "Zeta" },
195+
"model-g": { ...base, displayName: "Eta" },
196+
}
197+
198+
render(
199+
<ModelSelector apiConfiguration={{ ...anthropicConfig, apiModelId: "model-a" }} title="Select model" />,
200+
)
201+
fireEvent.click(screen.getByTestId("model-selector-trigger"))
202+
expect(screen.getByText("Beta Deep")).toBeInTheDocument()
203+
204+
fireEvent.change(screen.getByTestId("model-search-input"), { target: { value: "Beta Deep" } })
205+
206+
const items = screen.getAllByTestId("model-selector-item")
207+
expect(items).toHaveLength(1)
208+
expect(items[0]).toHaveTextContent("Beta Deep")
209+
210+
fireEvent.click(items[0])
211+
expect(vi.mocked(vscode.postMessage).mock.calls[0][0].values?.patch).toMatchObject({
212+
apiModelId: "model-b",
213+
})
214+
})
215+
})
216+
158217
test("hides the Bedrock custom-arn pseudo-model unless it is already selected", () => {
159218
staticModelsOverride.value = { "model-a": base, "custom-arn": base }
160219
const bedrockConfig: ProviderSettings = { apiProvider: providerIdentifiers.bedrock, apiModelId: "model-a" }

0 commit comments

Comments
 (0)