Repository navigation
Commit cb969ed
committed
u5a unit 5b: rank ancestor pins by the spelling that matched, and cover the accept path of a path-only pin
Two open review rows on this head were edits, and each lands here with a row that fails without it.
src/services/file-safety/safeWriteText.ts : _deepestPinnedDirectory accepted a candidate that matched
through either spelling but ranked them by the length of their dir field, so a pin that only reached
the created name through the location its alias resolved to could outrank a deeper pin whose own name
contains it, and the containment check then ran against the shallower location. A directory created
under the deep pin that became a link into the shallow one passed it. Candidates are now ranked by the
length of the spelling that actually matched the created name.
src/services/file-safety/__tests__/safeWriteText.spec.ts : two rows.
- "refuses to publish when a deeper pin covers the created name better than a longer alias spelling
does" (line 2241) is red on the pre-fix production file: promise resolved undefined instead of
rejecting, measured as 1 failed | 102 passed (103) with the head production file beside it, against
101 passed on the untouched head footing and 103 passed with this commit.
- "publishes when only the path form of the name pin is given and its parent resolves in place"
(line 2493) is the accept path the reject-only row left untested: under a mutant that refuses
path-form pins in the effective-parent selection it is red (2 failed | 101 passed, 103), and no row
in the block it was asked for was red under that mutant on the head footing (1 failed | 100 passed,
101), which is the hole the row closes.
Legs the repository hook would have run, carried rather than skipped:
- vitest.services.config.ts over services/file-safety/__tests__/safeWriteText.spec.ts +
safeWriteText.integration.spec.ts : 2 files passed, 106 tests passed, exit 0.
- prettier 3.9.10 (pinned isolated install) --check over the whole tree : All matched files use
Prettier code style, exit 0.
- tsc --noEmit in src : 429 error lines on this tree and 429 on the untouched head beside it, and
after stripping line and column numbers the two lists differ by zero lines; both exit 2 on the
pre-existing baseline of this checkout.
- knip --treat-config-hints-as-errors : byte-for-byte the same findings on this tree and on the head
footing (Unused files 1, Unused dependencies 2, Unlisted binaries 8, Unused exports 1, unused
exported enum members 4, configuration hints 2), exit 1 on both sides.
- eslint per file : not run. The pinned config cannot start on this host because @eslint/js is absent
from the install (Error [ERR_MODULE_NOT_FOUND] from packages/config-eslint/base.js), exit 2.
- src/eslint-suppressions.json : untouched, read back byte-identical to the head blob at 30,910 B.
No changeset, no CHANGELOG edit, no suppression added.1 parent 4a20286 commit cb969ed
2 files changed
Lines changed: 62 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2238 | 2238 | | |
2239 | 2239 | | |
2240 | 2240 | | |
| 2241 | + | |
| 2242 | + | |
| 2243 | + | |
| 2244 | + | |
| 2245 | + | |
| 2246 | + | |
| 2247 | + | |
| 2248 | + | |
| 2249 | + | |
| 2250 | + | |
| 2251 | + | |
| 2252 | + | |
| 2253 | + | |
| 2254 | + | |
| 2255 | + | |
| 2256 | + | |
| 2257 | + | |
| 2258 | + | |
| 2259 | + | |
| 2260 | + | |
| 2261 | + | |
| 2262 | + | |
| 2263 | + | |
| 2264 | + | |
| 2265 | + | |
| 2266 | + | |
| 2267 | + | |
| 2268 | + | |
| 2269 | + | |
| 2270 | + | |
| 2271 | + | |
| 2272 | + | |
| 2273 | + | |
| 2274 | + | |
| 2275 | + | |
| 2276 | + | |
| 2277 | + | |
| 2278 | + | |
| 2279 | + | |
| 2280 | + | |
2241 | 2281 | | |
2242 | 2282 | | |
2243 | 2283 | | |
| |||
2450 | 2490 | | |
2451 | 2491 | | |
2452 | 2492 | | |
| 2493 | + | |
| 2494 | + | |
| 2495 | + | |
| 2496 | + | |
| 2497 | + | |
| 2498 | + | |
| 2499 | + | |
| 2500 | + | |
| 2501 | + | |
| 2502 | + | |
| 2503 | + | |
| 2504 | + | |
2453 | 2505 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
423 | 423 | | |
424 | 424 | | |
425 | 425 | | |
| 426 | + | |
426 | 427 | | |
427 | 428 | | |
428 | 429 | | |
| |||
432 | 433 | | |
433 | 434 | | |
434 | 435 | | |
435 | | - | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
436 | 444 | | |
| 445 | + | |
437 | 446 | | |
438 | 447 | | |
439 | 448 | | |
| |||
0 commit comments