|
| 1 | +import type OpenAI from "openai" |
| 2 | +import type { ModeConfig } from "@roo-code/types" |
| 3 | +import type { CodeIndexManager } from "../../../../services/code-index/manager" |
| 4 | +import { filterNativeToolsForMode, getAvailableToolsInGroup, isToolAllowedInMode } from "../filter-tools-for-mode" |
| 5 | + |
| 6 | +type Readiness = Pick<CodeIndexManager, "isFeatureEnabled" | "isFeatureConfigured" | "isInitialized"> |
| 7 | + |
| 8 | +function makeManager(flags: Readiness): CodeIndexManager { |
| 9 | + // These filters only read the three public readiness getters; no manager services are needed. |
| 10 | + return flags as CodeIndexManager |
| 11 | +} |
| 12 | + |
| 13 | +const ready = { isFeatureEnabled: true, isFeatureConfigured: true, isInitialized: true } |
| 14 | +const nativeTools: OpenAI.Chat.ChatCompletionTool[] = [ |
| 15 | + "codebase_search", |
| 16 | + "read_file", |
| 17 | + "list_files", |
| 18 | + "search_files", |
| 19 | +].map((name) => ({ type: "function", function: { name, parameters: { type: "object", properties: {} } } })) |
| 20 | +const noReadMode: ModeConfig = { slug: "no-read", name: "No read", roleDefinition: "No reading", groups: ["command"] } |
| 21 | + |
| 22 | +function checkAvailability( |
| 23 | + manager: CodeIndexManager | undefined, |
| 24 | + expected: boolean, |
| 25 | + mode = "code", |
| 26 | + settings: { disabledTools?: string[] } = {}, |
| 27 | +) { |
| 28 | + const names = filterNativeToolsForMode(nativeTools, mode, [noReadMode], {}, manager, settings).flatMap((tool) => |
| 29 | + "function" in tool ? [tool.function.name] : [], |
| 30 | + ) |
| 31 | + const group = getAvailableToolsInGroup("read", mode, [noReadMode], {}, manager, settings) |
| 32 | + expect(names.includes("codebase_search")).toBe(expected) |
| 33 | + expect(isToolAllowedInMode("codebase_search", mode, [noReadMode], {}, manager, settings)).toBe(expected) |
| 34 | + expect(group.includes("codebase_search")).toBe(expected) |
| 35 | + for (const tool of ["read_file", "list_files", "search_files"] as const) { |
| 36 | + expect(names.includes(tool)).toBe(mode === "code") |
| 37 | + expect(isToolAllowedInMode(tool, mode, [noReadMode], {}, manager, settings)).toBe(mode === "code") |
| 38 | + expect(group.includes(tool)).toBe(mode === "code") |
| 39 | + } |
| 40 | +} |
| 41 | + |
| 42 | +describe("codebase_search readiness across mode filtering APIs", () => { |
| 43 | + it("excludes search without a manager while retaining ordinary read tools", () => { |
| 44 | + checkAvailability(undefined, false) |
| 45 | + }) |
| 46 | + |
| 47 | + for (const isFeatureEnabled of [false, true]) { |
| 48 | + for (const isFeatureConfigured of [false, true]) { |
| 49 | + for (const isInitialized of [false, true]) { |
| 50 | + it(`agrees for enabled=${isFeatureEnabled}, configured=${isFeatureConfigured}, initialized=${isInitialized}`, () => { |
| 51 | + checkAvailability( |
| 52 | + makeManager({ isFeatureEnabled, isFeatureConfigured, isInitialized }), |
| 53 | + isFeatureEnabled && isFeatureConfigured && isInitialized, |
| 54 | + ) |
| 55 | + }) |
| 56 | + } |
| 57 | + } |
| 58 | + } |
| 59 | + |
| 60 | + it.each(["isFeatureEnabled", "isFeatureConfigured", "isInitialized"] as const)( |
| 61 | + "rereads live %s changes", |
| 62 | + (flag) => { |
| 63 | + const flags = { ...ready } |
| 64 | + const manager = makeManager(flags) |
| 65 | + checkAvailability(manager, true) |
| 66 | + flags[flag] = false |
| 67 | + checkAvailability(manager, false) |
| 68 | + flags[flag] = true |
| 69 | + checkAvailability(manager, true) |
| 70 | + }, |
| 71 | + ) |
| 72 | + |
| 73 | + it("keeps alternating managers isolated", () => { |
| 74 | + const enabled = makeManager({ ...ready }) |
| 75 | + const disabled = makeManager({ ...ready, isFeatureEnabled: false }) |
| 76 | + checkAvailability(enabled, true) |
| 77 | + checkAvailability(disabled, false) |
| 78 | + checkAvailability(undefined, false) |
| 79 | + checkAvailability(enabled, true) |
| 80 | + }) |
| 81 | + |
| 82 | + it("does not bypass a mode without the read group", () => { |
| 83 | + checkAvailability(makeManager({ ...ready }), false, "no-read") |
| 84 | + }) |
| 85 | + |
| 86 | + it("does not bypass disabledTools with a ready manager", () => { |
| 87 | + checkAvailability(makeManager({ ...ready }), false, "code", { disabledTools: ["codebase_search"] }) |
| 88 | + }) |
| 89 | +}) |
0 commit comments