Repository navigation
Commit c2206c5
committed
fix(core,webview): confirm the newest resolved write and restore the deletion suite's members
rt4474947849: ContextProxy.updateGlobalState accepted a resolved write as confirmed only while
it still owned the key's generation, so an older write that resolved after a newer write had
started left `confirmed` holding the pre-write value, and a later rejection restored something
no storage ever held. The success path now accepts any resolved write that is newer than the
most recently confirmed generation for the key and mutates the entry in place; the generation
check stays on the restore path alone. ContextProxy.globalStateRestore.spec.ts adds the
A-resolves / B-rejects case and asserts that both getGlobalState(KEY) and storage read "a".
rt4474947862: the deleteApiConfiguration suite in webviewMessageHandler.spec.ts reassigns
providerSettingsManager and deleteProviderProfile and never put them back, so the doomed-profile
fixture leaked into any later test that reads either member without setting its own value. An
afterEach now restores both, matching the snapshot-and-restore the rename and launch suites in
the same file already do; the activation-warning case keeps its own suite so this head stays on
the leak fix rather than a suite reshuffle.1 parent 2172fcd commit c2206c5
3 files changed
Lines changed: 50 additions & 10 deletions
File tree
- src/core
- config
- __tests__
- webview/__tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
56 | 59 | | |
57 | 60 | | |
58 | 61 | | |
| |||
73 | 76 | | |
74 | 77 | | |
75 | 78 | | |
76 | | - | |
| 79 | + | |
77 | 80 | | |
78 | 81 | | |
79 | 82 | | |
| |||
382 | 385 | | |
383 | 386 | | |
384 | 387 | | |
385 | | - | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
386 | 393 | | |
387 | 394 | | |
388 | 395 | | |
389 | 396 | | |
390 | | - | |
391 | | - | |
392 | | - | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
393 | 402 | | |
394 | | - | |
| 403 | + | |
395 | 404 | | |
| 405 | + | |
396 | 406 | | |
397 | 407 | | |
398 | 408 | | |
399 | 409 | | |
400 | | - | |
401 | | - | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
402 | 413 | | |
403 | 414 | | |
404 | 415 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
43 | 46 | | |
44 | 47 | | |
45 | 48 | | |
| |||
110 | 113 | | |
111 | 114 | | |
112 | 115 | | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
113 | 130 | | |
114 | 131 | | |
115 | 132 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2273 | 2273 | | |
2274 | 2274 | | |
2275 | 2275 | | |
| 2276 | + | |
| 2277 | + | |
| 2278 | + | |
| 2279 | + | |
| 2280 | + | |
| 2281 | + | |
| 2282 | + | |
| 2283 | + | |
| 2284 | + | |
| 2285 | + | |
| 2286 | + | |
| 2287 | + | |
2276 | 2288 | | |
2277 | 2289 | | |
2278 | 2290 | | |
| |||
0 commit comments