Repository navigation
Commit bafdf4d
committed
Answer the three review rows at 932c9a4 with the cases they name
Run the partial-observation cleanup tests against a real ObservationRegistry, so the
entry the failure exit decides about is the object the registry actually stored: a
stand-in that builds a fresh object on every lookup cannot show ownership at all, and
the two rows that name a concurrent read could only assert on doubles. A concurrent
complete read that records this very version keeps its entry, the entry this call
created is still forgotten while it is the recorded one, and a partial concurrent read
behind the same version is forgotten too - that is where matching fields and ownership
part company, recorded as production behaves it, with no production line moved.
Add the ARN the settings row says is missing: the Bedrock spec now rerenders the same
tree with a matching ARN after the mismatch, asserts the region warning is gone, that
the format error is still absent, and that the input carries the new ARN.
Add the accept path the provider-validation row pins at the line it names: a model
that is in the fetched routerModels list earns no error from getModelValidationError,
beside the rejection case that was already there.
Legs run before this commit, each transcript under .tmp-cr-audit/_scratch/u181: the src
core vitest leg on applyDiffTool.failureReporting printed 37 tests passed in 1 file
before the change and 38 in 1 file after; the Bedrock ARN spec printed 2 before and 3
after; validate.provider-validation printed 18 before and 19 after. Each new assertion
was inverted once: flipping the keep case's forget expectation failed that test with
'expected forget to be called at least once'; asking for the regionMismatch text after
the matching rerender failed it with TestingLibraryElementError, unable to find
/regionMismatch/; asking the accept path to be defined failed with 'expected undefined
to be defined'. Every file was written back to the digest its passing run used.
The first push attempt was stopped by the pre-push hook: its check-types leg reported
TS2540 on assigning the installed registry to the read-only Task property. The case now
holds a mutable view of the double for that one assignment, src tsc --noEmit is silent,
and the root check-types leg finished 12 successful, 12 total; the src vitest leg was
run again on the fixed file and printed 38 passed in 1 file, and the inverted keep-case
expectation failed it again before the file was written back.
prettier 3.9.10 --check passes on all three files. eslint under --max-warnings=0 printed
nothing on each, and an injected unused variable made the same command fail on the same
file, so those legs read the files instead of ignoring them.
src/eslint-suppressions.json stayed 30910 B, byte identical to its head blob: no count
moved, no suppression was added, and the --prune-suppressions line-ending rewrite it
made was written back from that blob.1 parent 932c9a4 commit bafdf4d
3 files changed
Lines changed: 116 additions & 13 deletions
File tree
- src/core/tools/__tests__
- webview-ui/src
- components/settings/providers/__tests__
- utils/__tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
| 7 | + | |
6 | 8 | | |
7 | 9 | | |
8 | 10 | | |
| |||
538 | 540 | | |
539 | 541 | | |
540 | 542 | | |
541 | | - | |
542 | | - | |
543 | | - | |
544 | | - | |
545 | | - | |
546 | | - | |
547 | | - | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
548 | 561 | | |
549 | | - | |
550 | | - | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
551 | 571 | | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
552 | 590 | | |
553 | 591 | | |
554 | 592 | | |
555 | | - | |
| 593 | + | |
556 | 594 | | |
557 | 595 | | |
558 | 596 | | |
559 | | - | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
560 | 603 | | |
561 | 604 | | |
562 | 605 | | |
563 | | - | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
564 | 621 | | |
565 | 622 | | |
566 | 623 | | |
567 | | - | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
568 | 630 | | |
569 | 631 | | |
570 | 632 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
106 | 138 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
179 | 179 | | |
180 | 180 | | |
181 | 181 | | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
182 | 191 | | |
0 commit comments