Repository navigation
Commit b6341af
committed
fix: keep headless task creation working when the webview never launches,
catch IPC start failures, harden two readiness/ordering tests
Review round on this unit: (1) the view-state readiness bound rejected
every startNewTask whose webview never launched, breaking headless API
callers that previously created tasks against the shared-state fallback -
the bound now only rejects when the webview has launched (a launched view
whose readiness failed is a real failure); the IPC StartNewTask listener
also catches rejections, since IpcServer does not await async listeners
and an uncaught rejection surfaces as an unhandled rejection in the
extension host. (2) The readiness-cancel test proved cancellation with a
global clearTimeout spy, which also fires for the flush sleep and library
internals - it now runs on fake timers and asserts the timer count drops
to zero, pinning the readiness bound's own timer. (3) The mode-ordering
test only checked the end state, so it passed even if submitUserMessage
dropped its wait for the pending initialization - it now asserts the
switch has not been called before the pending state is released.
Proofs: Task.spec 190/190, api-task-control 26/26 (new headless-fallback
and launched-stuck tests green); negative controls: dropping the
waitForModeInitialization await reddens exactly the ordering test's new
in-flight assertion, dropping the readiness timer's clearTimeout reddens
exactly the timer-count assertion, making the timeout unconditional
reddens exactly the headless-fallback test, restores byte-exact (hash
match); eslint --max-warnings=0 clean; prettier clean.1 parent 320fd43 commit b6341af
3 files changed
Lines changed: 96 additions & 19 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3839 | 3839 | | |
3840 | 3840 | | |
3841 | 3841 | | |
| 3842 | + | |
| 3843 | + | |
| 3844 | + | |
| 3845 | + | |
| 3846 | + | |
| 3847 | + | |
| 3848 | + | |
| 3849 | + | |
3842 | 3850 | | |
3843 | 3851 | | |
3844 | 3852 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
198 | 198 | | |
199 | 199 | | |
200 | 200 | | |
201 | | - | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
202 | 205 | | |
203 | 206 | | |
204 | 207 | | |
205 | 208 | | |
206 | 209 | | |
207 | 210 | | |
208 | | - | |
| 211 | + | |
209 | 212 | | |
210 | 213 | | |
211 | | - | |
212 | | - | |
213 | | - | |
214 | | - | |
215 | | - | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
216 | 263 | | |
217 | 264 | | |
218 | 265 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
110 | | - | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
111 | 119 | | |
112 | 120 | | |
113 | 121 | | |
| |||
231 | 239 | | |
232 | 240 | | |
233 | 241 | | |
234 | | - | |
235 | | - | |
236 | | - | |
237 | | - | |
238 | | - | |
239 | | - | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | | - | |
244 | | - | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
245 | 267 | | |
246 | 268 | | |
247 | 269 | | |
| |||
0 commit comments