Repository navigation
Commit b3c0116
committed
fix(api): attribute poe timeouts only to the timeout this method configured
The reviewer reads abortedByTimeout() as reporting a timeout whenever the merged
signal's reason is named TimeoutError, and AbortSignal.timeout() produces exactly that
reason: a caller that passes a timeout signal without timeoutMs was reported as this
provider timing out, which is the wrong contract for a caller-side abort.
Classification now requires a timeout this method actually configured
(hasUsableTimeout(options?.timeoutMs)) on top of the aborted flag and the reason name,
so a caller-only timeout abort lands on the AbortError contract. Where a caller timeout
signal and our own timeoutMs both exist the two reasons are indistinguishable and the
timeout reading still wins, matching the series contract; that residual is stated in
the comment at the classification site.
Control measured in src: the new case 'reports a caller timeout abort as AbortError
when no per-request timeout is configured' is red without the added condition (1 failed
of 44) and green with it (44 passed); the suite at HEAD was 43 passed, so the delta is
exactly the new case.
Verified on this head: tsc -p tsconfig.json --noEmit clean, eslint --max-warnings=0
clean on the two touched files, prettier --check clean, poe spec 44/44 with
--no-file-parallelism. src/eslint-suppressions.json untouched; no changeset, no CHANGELOG.1 parent 0a23408 commit b3c0116
2 files changed
Lines changed: 33 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
863 | 863 | | |
864 | 864 | | |
865 | 865 | | |
| 866 | + | |
| 867 | + | |
| 868 | + | |
| 869 | + | |
| 870 | + | |
| 871 | + | |
| 872 | + | |
| 873 | + | |
| 874 | + | |
| 875 | + | |
| 876 | + | |
| 877 | + | |
| 878 | + | |
| 879 | + | |
| 880 | + | |
| 881 | + | |
| 882 | + | |
| 883 | + | |
| 884 | + | |
866 | 885 | | |
867 | 886 | | |
868 | 887 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
37 | 42 | | |
38 | 43 | | |
39 | 44 | | |
| |||
249 | 254 | | |
250 | 255 | | |
251 | 256 | | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
252 | 264 | | |
253 | 265 | | |
| 266 | + | |
254 | 267 | | |
255 | 268 | | |
256 | 269 | | |
| |||
0 commit comments