Repository navigation
Commit b2b31f7
committed
refactor(dte): drop the U5 reasoning pair and the duplicated U1 surface
This PR's scope is the transient task-local thinking effort on Task.ts, its per-request
delivery at the four createMessage sites, the profile-switch re-capture, and the tests for
that behaviour. Two groups of changes here belong to sibling units and are removed.
src/api/transform/reasoning.ts gained the adaptive-envelope effort set and the shared
effective-effort resolver, together with the spec that covers only those two exports. They
belong to the adaptive-envelope unit, whose own branch carries the same pair. Nothing in this
unit's code reads them - the only importer in the tree is the pair's own spec - so removing both
leaves Task.ts, the metadata field in src/api/index.ts and the task tests untouched.
The eighteen webview-ui/src/i18n/locales/*/settings.json additions, the experimental-settings
gallery entry in webview-ui/playwright/gallery/stories.tsx, the ExperimentalSettings visual story
and fixture, and the four experimental-settings baselines are the dynamic-thinking-effort setting
surface the dynamic-thinking-effort unit already ships. This unit does not render that control:
its ExperimentalSettings case asserts the toggle stays hidden, and it asserts on translation keys
rather than translated strings, so dropping the copies cannot change what it proves.
The locale-loading awaits come out with them. The await loadLanguage calls existed because the
eighteen new setting keys moved the Korean bundle out of the eager entry chunk and the spec's
timing assertions started racing that fetch; with the keys gone the calls are no longer needed.
Measured on this tree: with the awaits the spec passes 3/3 with CI=true, without them it passes
8/8 with CI=true and 4/4 with CI unset, and neither variant logs a "not wrapped in act(...)"
warning, so the change is dropped instead of restructured.
Tests: core/task/__tests__/Task.runtime-thinking-effort.test.ts, core/webview/__tests__
ClineProvider.spec.ts and webviewMessageHandler.spec.ts and shared/__tests__/experiments.spec.ts
pass together (4 files, 466 tests); the webview-ui i18n suites and ExperimentalSettings pass
(5 files, 18 tests) and the SettingsView suites pass (3 files, 53 tests). tsc --noEmit is clean
for both src and webview-ui.1 parent b1d2d58 commit b2b31f7
28 files changed
Lines changed: 0 additions & 248 deletions
File tree
- src/api/transform
- __tests__
- webview-ui
- playwright/gallery
- src
- components/settings/__tests__
- __screenshots__
- i18n
- __tests__
- locales
- ca
- de
- en
- es
- fr
- hi
- id
- it
- ja
- ko
- nl
- pl
- pt-BR
- ru
- tr
- vi
- zh-CN
- zh-TW
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | 36 | | |
84 | 37 | | |
85 | 38 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
419 | 419 | | |
420 | 420 | | |
421 | 421 | | |
422 | | - | |
423 | | - | |
424 | | - | |
425 | | - | |
426 | | - | |
427 | 422 | | |
428 | 423 | | |
429 | 424 | | |
| |||
This file was deleted.
This file was deleted.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | 50 | | |
60 | 51 | | |
61 | 52 | | |
| |||
76 | 67 | | |
77 | 68 | | |
78 | 69 | | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | 70 | | |
83 | 71 | | |
84 | 72 | | |
| |||
96 | 84 | | |
97 | 85 | | |
98 | 86 | | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | 87 | | |
103 | 88 | | |
104 | 89 | | |
| |||
120 | 105 | | |
121 | 106 | | |
122 | 107 | | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | 108 | | |
127 | 109 | | |
128 | 110 | | |
| |||
141 | 123 | | |
142 | 124 | | |
143 | 125 | | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | 126 | | |
149 | 127 | | |
150 | 128 | | |
| |||
0 commit comments