Skip to content

Commit b2a7f80

Browse files
committed
test: move auto-close settings tests to ClineProvider.spec.ts and assert all three fields
Address review comments on PR #668: - Move the auto-close settings test block from ClineProvider.taskHistory.spec.ts to ClineProvider.spec.ts, where existing getState settings coverage (autoCondenseContext, writeDelayMs) already lives. - Expand the getState regression test to assert autoCloseZooOpenedFiles, autoCloseZooOpenedFilesAfterUserEdited, and autoCloseZooOpenedNewFiles so a regression dropping any of the three fields is caught.
1 parent 3115873 commit b2a7f80

2 files changed

Lines changed: 50 additions & 45 deletions

File tree

‎src/core/webview/__tests__/ClineProvider.spec.ts‎

Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1010,6 +1010,56 @@ describe("ClineProvider", () => {
10101010
expect(mockPostMessage).toHaveBeenCalled()
10111011
})
10121012

1013+
describe("auto-close settings are included in posted state", () => {
1014+
it("getStateToPostToWebview returns saved autoCloseZooOpenedFiles value", async () => {
1015+
await provider.resolveWebviewView(mockWebviewView)
1016+
1017+
// Simulate the updateSettings handler storing the value.
1018+
await provider.contextProxy.setValue("autoCloseZooOpenedFiles", false)
1019+
await provider.contextProxy.setValue("autoCloseZooOpenedFilesAfterUserEdited", true)
1020+
await provider.contextProxy.setValue("autoCloseZooOpenedNewFiles", true)
1021+
1022+
const state = await provider.getStateToPostToWebview()
1023+
1024+
// The saved values must be present in the state posted to the webview.
1025+
expect(state.autoCloseZooOpenedFiles).toBe(false)
1026+
expect(state.autoCloseZooOpenedFilesAfterUserEdited).toBe(true)
1027+
expect(state.autoCloseZooOpenedNewFiles).toBe(true)
1028+
})
1029+
1030+
it("getStateToPostToWebview defaults autoCloseZooOpenedFiles to true when unset", async () => {
1031+
await provider.resolveWebviewView(mockWebviewView)
1032+
1033+
// Ensure the settings are not set.
1034+
await provider.contextProxy.setValue("autoCloseZooOpenedFiles", undefined)
1035+
await provider.contextProxy.setValue("autoCloseZooOpenedFilesAfterUserEdited", undefined)
1036+
await provider.contextProxy.setValue("autoCloseZooOpenedNewFiles", undefined)
1037+
1038+
const state = await provider.getStateToPostToWebview()
1039+
1040+
// Unset values should default to their documented defaults.
1041+
expect(state.autoCloseZooOpenedFiles).toBe(true)
1042+
expect(state.autoCloseZooOpenedFilesAfterUserEdited).toBe(false)
1043+
expect(state.autoCloseZooOpenedNewFiles).toBe(false)
1044+
})
1045+
1046+
it("getState returns saved autoCloseZooOpenedFiles value for DiffViewProvider", async () => {
1047+
await provider.resolveWebviewView(mockWebviewView)
1048+
1049+
await provider.contextProxy.setValue("autoCloseZooOpenedFiles", false)
1050+
await provider.contextProxy.setValue("autoCloseZooOpenedFilesAfterUserEdited", true)
1051+
await provider.contextProxy.setValue("autoCloseZooOpenedNewFiles", true)
1052+
1053+
const state = await provider.getState()
1054+
1055+
// DiffViewProvider reads from getState(); all three fields must be present
1056+
// so a regression that drops any of them is caught.
1057+
expect(state.autoCloseZooOpenedFiles).toBe(false)
1058+
expect(state.autoCloseZooOpenedFilesAfterUserEdited).toBe(true)
1059+
expect(state.autoCloseZooOpenedNewFiles).toBe(true)
1060+
})
1061+
})
1062+
10131063
it("loads saved API config when switching modes", async () => {
10141064
await provider.resolveWebviewView(mockWebviewView)
10151065
const messageHandler = (mockWebviewView.webview.onDidReceiveMessage as any).mock.calls[0][0]

‎src/core/webview/__tests__/ClineProvider.taskHistory.spec.ts‎

Lines changed: 0 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -685,51 +685,6 @@ describe("ClineProvider Task History Synchronization", () => {
685685
})
686686
})
687687

688-
describe("auto-close settings are included in posted state", () => {
689-
it("getStateToPostToWebview returns saved autoCloseZooOpenedFiles value", async () => {
690-
await provider.resolveWebviewView(mockWebviewView)
691-
692-
// Simulate the updateSettings handler storing the value.
693-
await provider.contextProxy.setValue("autoCloseZooOpenedFiles", false)
694-
await provider.contextProxy.setValue("autoCloseZooOpenedFilesAfterUserEdited", true)
695-
await provider.contextProxy.setValue("autoCloseZooOpenedNewFiles", true)
696-
697-
const state = await provider.getStateToPostToWebview()
698-
699-
// The saved values must be present in the state posted to the webview.
700-
expect(state.autoCloseZooOpenedFiles).toBe(false)
701-
expect(state.autoCloseZooOpenedFilesAfterUserEdited).toBe(true)
702-
expect(state.autoCloseZooOpenedNewFiles).toBe(true)
703-
})
704-
705-
it("getStateToPostToWebview defaults autoCloseZooOpenedFiles to true when unset", async () => {
706-
await provider.resolveWebviewView(mockWebviewView)
707-
708-
// Ensure the settings are not set.
709-
await provider.contextProxy.setValue("autoCloseZooOpenedFiles", undefined)
710-
await provider.contextProxy.setValue("autoCloseZooOpenedFilesAfterUserEdited", undefined)
711-
await provider.contextProxy.setValue("autoCloseZooOpenedNewFiles", undefined)
712-
713-
const state = await provider.getStateToPostToWebview()
714-
715-
// Unset values should default to their documented defaults.
716-
expect(state.autoCloseZooOpenedFiles).toBe(true)
717-
expect(state.autoCloseZooOpenedFilesAfterUserEdited).toBe(false)
718-
expect(state.autoCloseZooOpenedNewFiles).toBe(false)
719-
})
720-
721-
it("getState returns saved autoCloseZooOpenedFiles value for DiffViewProvider", async () => {
722-
await provider.resolveWebviewView(mockWebviewView)
723-
724-
await provider.contextProxy.setValue("autoCloseZooOpenedFiles", false)
725-
726-
const state = await provider.getState()
727-
728-
// DiffViewProvider reads from getState(); the field must be present.
729-
expect(state.autoCloseZooOpenedFiles).toBe(false)
730-
})
731-
})
732-
733688
describe("taskHistory write lock (mutex)", () => {
734689
it("serializes concurrent updateTaskHistory calls so no entries are lost", async () => {
735690
await provider.resolveWebviewView(mockWebviewView)

0 commit comments

Comments
 (0)