Repository navigation
Commit afb629e
committed
fix(core): derive a profile's secret keys from its provider as well as its blob
What: `getProfileSecretKeys` now returns the union of the keys the blob declares
and the keys the profile's own `apiProvider` owns, both drawn from
`PROVIDER_SECRET_KEYS`.
Why: `api.getConfiguration()` strips secret fields, so a profile saved from that
round trip declares no secret while its live credential is still in
SecretStorage. Deleting that profile purged zero keys and left the credential
behind indefinitely.
Impact: a deleted profile's own credentials are removed even when its blob is
secret-less. A provider with no ownership branch keeps the presence-based
answer, and the surviving-profile keep-set is derived from the same candidate
set, so it can only grow. Net 0 counted executable lines.
Tests: three cases pin the union, the declared-key path, and the retired-provider
fallback.1 parent 3b2f073 commit afb629e
2 files changed
Lines changed: 48 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | | - | |
| 96 | + | |
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
103 | 108 | | |
104 | 109 | | |
105 | 110 | | |
106 | 111 | | |
107 | | - | |
| 112 | + | |
108 | 113 | | |
109 | 114 | | |
110 | 115 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
576 | 576 | | |
577 | 577 | | |
578 | 578 | | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
579 | 619 | | |
580 | 620 | | |
581 | 621 | | |
| |||
0 commit comments