Skip to content

Commit aedeaa9

Browse files
committed
chore: address review feedback and add coverage instructions from #1497
1 parent 0affa20 commit aedeaa9

1 file changed

Lines changed: 11 additions & 1 deletion

File tree

‎.coderabbit.yaml‎

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ reviews:
2929
enabled: false
3030
drafts: false
3131
auto_incremental_review: true
32-
auto_pause_after_reviewed_commits: 5
32+
auto_pause_after_reviewed_commits: 0
3333
labels:
3434
- "coderabbit-review-active"
3535

@@ -63,6 +63,8 @@ reviews:
6363
cancellation, retry, and compatibility paths. Verify promises and errors are handled,
6464
existing helpers are reused, and new code introduces no `any`, unjustified double
6565
assertions, floating promises, duplicated helpers, or increased lint suppressions.
66+
When a refactor adds early-return guards that redirect a subset of inputs to a new
67+
code path, confirm the old branches for those inputs are removed or unreachable.
6668
6769
- path: "{**/*.{test,spec}.{ts,tsx,js,jsx},**/__tests__/**}"
6870
instructions: >-
@@ -78,6 +80,11 @@ reviews:
7880
Flag tests that assert in-flight behavior only after the call completes — these cannot
7981
prove the behavior fires during execution. Check that describe block names match the
8082
actual subjects of the tests they contain.
83+
For tests that assert only mock call counts, confirm a corresponding return-value
84+
assertion exists; a regression that silently returns stale fallback data can satisfy
85+
a call-count check. For code with fallback behavior, verify both the cold-start case
86+
(no prior state) and the warm case (prior state exists) are covered, as they exercise
87+
different branches.
8188
8289
- path: "apps/vscode-e2e/**"
8390
instructions: >-
@@ -117,6 +124,9 @@ reviews:
117124
Check persistence and lifecycle invariants: awaited atomic writes, rollback or explicit
118125
partial-failure behavior, cross-window state consistency, stale listeners/watchers,
119126
cancellation, idempotency, and safe restart/resume without lost or duplicated state.
127+
For async functions that read shared mutable state before an `await` and write it back
128+
after, verify the captured reference is still valid when the write executes; a concurrent
129+
mutation during the await can cause a stale snapshot to overwrite a newer state.
120130
121131
- path: ".github/**"
122132
instructions: >-

0 commit comments

Comments
 (0)