Skip to content

Commit abaf732

Browse files
myk1ytZoo (VP)
andauthored
fix(kimi-code): correct maxTokens defaults and add server-side override (#1217)
* fix(kimi-code): correct maxTokens defaults and add server-side override Fixes #1215 - Update kimiCodeDefaultModelInfo.maxTokens from 32768 to 131072 - Add kimiCodeModelDefaults for per-model fallback values - Add max_tokens to kimiCodeModelSchema for server response parsing - Override maxTokens in mapKimiCodeModel: server > model-default > global-default - Add 4 new tests for maxTokens override and fallback behavior * refactor(kimi-code): address PR review comments - Replace production constant imports in tests with hardcoded fixture values - Add .int() validation to max_tokens Zod schema - Add fractional max_tokens rejection test - Export kimiCodeModelSchema for test access --------- Co-authored-by: Zoo (VP) <[email protected]>
1 parent fcc507c commit abaf732

3 files changed

Lines changed: 67 additions & 3 deletions

File tree

‎packages/types/src/providers/kimi-code.ts‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ export const kimiCodeReasoningEfforts = ["low", "high", "max"] as const
77

88
export const kimiCodeDefaultModelInfo: ModelInfo = {
99
contextWindow: 262_144,
10-
maxTokens: 32_768,
10+
maxTokens: 131_072,
1111
supportsImages: false,
1212
supportsPromptCache: false,
1313
supportsReasoningEffort: [...kimiCodeReasoningEfforts],
@@ -16,6 +16,13 @@ export const kimiCodeDefaultModelInfo: ModelInfo = {
1616
description: "Kimi Code's coding model for subscription and API-key access.",
1717
}
1818

19+
export const kimiCodeModelDefaults: Record<string, { maxTokens: number }> = {
20+
k3: { maxTokens: 131_072 },
21+
"k3-256k": { maxTokens: 131_072 },
22+
"kimi-for-coding": { maxTokens: 131_072 },
23+
"kimi-for-coding-highspeed": { maxTokens: 131_072 },
24+
}
25+
1926
export const kimiCodeModels = {
2027
[kimiCodeDefaultModelId]: kimiCodeDefaultModelInfo,
2128
} as const satisfies Record<string, ModelInfo>

‎src/api/providers/fetchers/__tests__/kimi-code.spec.ts‎

Lines changed: 54 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { getKimiCodeModels, mapKimiCodeModel } from "../kimi-code"
1+
import { getKimiCodeModels, kimiCodeModelSchema, mapKimiCodeModel } from "../kimi-code"
22

33
describe("Kimi Code model discovery", () => {
44
beforeEach(() => vi.restoreAllMocks())
@@ -97,4 +97,57 @@ describe("Kimi Code model discovery", () => {
9797
expect(vi.mocked(fetch).mock.calls[0][1]?.signal?.aborted).toBe(true)
9898
expect(vi.getTimerCount()).toBe(0)
9999
})
100+
101+
it("overrides maxTokens from server max_tokens in mapKimiCodeModel", () => {
102+
const mapped = mapKimiCodeModel({
103+
id: "kimi-for-coding",
104+
max_tokens: 200_000,
105+
})
106+
expect(mapped.maxTokens).toBe(200_000)
107+
})
108+
109+
it("overrides maxTokens from server max_tokens at fetcher level in getKimiCodeModels", async () => {
110+
vi.spyOn(globalThis, "fetch").mockResolvedValue(
111+
new Response(
112+
JSON.stringify({
113+
data: [{ id: "kimi-for-coding", context_length: 262144, max_tokens: 200_000 }],
114+
}),
115+
{ status: 200 },
116+
),
117+
)
118+
const models = await getKimiCodeModels("token")
119+
expect(models["kimi-for-coding"].maxTokens).toBe(200_000)
120+
})
121+
122+
it("falls back to per-model defaults for known model ids", () => {
123+
const expected: Record<string, number> = {
124+
k3: 131_072,
125+
"k3-256k": 131_072,
126+
"kimi-for-coding": 131_072,
127+
"kimi-for-coding-highspeed": 131_072,
128+
}
129+
for (const [modelId, maxTokens] of Object.entries(expected)) {
130+
const mapped = mapKimiCodeModel({ id: modelId })
131+
expect(mapped.maxTokens).toBe(maxTokens)
132+
}
133+
})
134+
135+
it("falls back to kimiCodeDefaultModelInfo.maxTokens for unknown model ids", () => {
136+
const mapped = mapKimiCodeModel({ id: "unknown-model" })
137+
expect(mapped.maxTokens).toBe(131_072)
138+
})
139+
140+
it("rejects fractional max_tokens from server response", () => {
141+
const mapped = mapKimiCodeModel({
142+
id: "kimi-for-coding",
143+
max_tokens: 131072.5,
144+
})
145+
// Zod .int() would reject at schema level, but mapKimiCodeModel receives
146+
// already-parsed data. Verify the schema rejects fractional values.
147+
const result = kimiCodeModelSchema.safeParse({
148+
id: "kimi-for-coding",
149+
max_tokens: 131072.5,
150+
})
151+
expect(result.success).toBe(false)
152+
})
100153
})

‎src/api/providers/fetchers/kimi-code.ts‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,16 @@ import { z } from "zod"
33
import {
44
KIMI_CODE_BASE_URL,
55
kimiCodeDefaultModelInfo,
6+
kimiCodeModelDefaults,
67
kimiCodeReasoningEfforts,
78
type ModelInfo,
89
type ModelRecord,
910
} from "@roo-code/types"
1011

11-
const kimiCodeModelSchema = z.object({
12+
export const kimiCodeModelSchema = z.object({
1213
id: z.string().min(1),
1314
context_length: z.number().positive().optional(),
15+
max_tokens: z.number().int().positive().optional(),
1416
supports_reasoning: z.boolean().optional(),
1517
supports_image_in: z.boolean().optional(),
1618
display_name: z.string().optional(),
@@ -22,9 +24,11 @@ const KIMI_CODE_MODELS_TIMEOUT_MS = 10_000
2224

2325
export function mapKimiCodeModel(model: z.infer<typeof kimiCodeModelSchema>): ModelInfo {
2426
const supportsReasoning = model.supports_reasoning ?? false
27+
const defaults = kimiCodeModelDefaults[model.id] ?? {}
2528
return {
2629
...kimiCodeDefaultModelInfo,
2730
contextWindow: model.context_length ?? kimiCodeDefaultModelInfo.contextWindow,
31+
maxTokens: model.max_tokens ?? defaults.maxTokens ?? kimiCodeDefaultModelInfo.maxTokens,
2832
supportsReasoningEffort: supportsReasoning ? [...kimiCodeReasoningEfforts] : false,
2933
requiredReasoningEffort: supportsReasoning,
3034
reasoningEffort: supportsReasoning ? "max" : undefined,

0 commit comments

Comments
 (0)