Skip to content

Commit 9e5c92c

Browse files
committed
test(ci): strengthen WASM dependency contract
1 parent a58036a commit 9e5c92c

2 files changed

Lines changed: 22 additions & 3 deletions

File tree

‎src/scripts/verify-coverage-contract.mjs‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ if (!coverageTask) throw new Error("Unit coverage task missing")
2222
if (graph.tasks.some(({ taskId }) => taskId === "zoo-code#prepare:tree-sitter-wasms"))
2323
throw new Error("Removed WASM preparation task remains in the graph")
2424
if (coverageTask.dependencies.includes("zoo-code#bundle")) throw new Error("Unit coverage must not depend on bundle")
25+
if (!coverageTask.dependencies.includes("@roo-code/types#build"))
26+
throw new Error("Unit coverage must depend on the types build")
2527
if (!Object.hasOwn(coverageTask.inputs, "package.json")) throw new Error("Unit coverage must hash package.json")
2628
if (!coverageTask.hashOfExternalDependencies) throw new Error("Unit coverage must hash external dependencies")
2729
if (!distTask?.dependencies.includes("zoo-code#bundle")) throw new Error("Dist smoke test must depend on bundle")

‎src/services/tree-sitter/__tests__/wasm.spec.ts‎

Lines changed: 20 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,21 +39,37 @@ const requiredGrammars = [
3939
"zig",
4040
]
4141

42+
async function captureLoadFailure(filename: string, directory: string) {
43+
let error: unknown
44+
try {
45+
await loadTestGrammar(filename, directory)
46+
} catch (caught) {
47+
error = caught
48+
}
49+
if (!(error instanceof Error) || !(error.cause instanceof Error)) {
50+
throw new Error("Expected a contextual grammar load error with an Error cause")
51+
}
52+
expect(error.message).toContain(error.cause.message)
53+
return error
54+
}
55+
4256
describe("dependency-owned Tree-sitter grammars", () => {
4357
const temporaryDirectories: string[] = []
4458

4559
beforeAll(() => Parser.init())
4660
afterEach(() => temporaryDirectories.splice(0).forEach((directory) => fs.rmSync(directory, { recursive: true })))
4761

4862
it.each(requiredGrammars)("loads tree-sitter-%s.wasm", async (grammar) => {
49-
await expect(loadTestGrammar(`tree-sitter-${grammar}.wasm`)).resolves.toBeDefined()
63+
const language = await loadTestGrammar(`tree-sitter-${grammar}.wasm`)
64+
expect(() => new Parser().setLanguage(language)).not.toThrow()
5065
})
5166

5267
it("reports a missing dependency artifact with its filename and resolved path", async () => {
5368
const directory = fs.mkdtempSync(path.join(os.tmpdir(), "tree-sitter-wasm-missing-"))
5469
temporaryDirectories.push(directory)
5570

56-
await expect(loadTestGrammar("tree-sitter-missing.wasm", directory)).rejects.toThrow(
71+
const error = await captureLoadFailure("tree-sitter-missing.wasm", directory)
72+
expect(error.message).toContain(
5773
`Failed to load Tree-sitter grammar tree-sitter-missing.wasm from ${path.join(directory, "tree-sitter-missing.wasm")}`,
5874
)
5975
})
@@ -63,7 +79,8 @@ describe("dependency-owned Tree-sitter grammars", () => {
6379
temporaryDirectories.push(directory)
6480
fs.writeFileSync(path.join(directory, "tree-sitter-malformed.wasm"), "not wasm")
6581

66-
await expect(loadTestGrammar("tree-sitter-malformed.wasm", directory)).rejects.toThrow(
82+
const error = await captureLoadFailure("tree-sitter-malformed.wasm", directory)
83+
expect(error.message).toContain(
6784
`Failed to load Tree-sitter grammar tree-sitter-malformed.wasm from ${path.join(directory, "tree-sitter-malformed.wasm")}`,
6885
)
6986
})

0 commit comments

Comments
 (0)