Repository navigation
Commit 9dea54e
easonLiangWorldedtech
fix(gate): align selection, source reads, and mutation to one tree; reject a partial stacked map
Two findings from the review at head:
1. Functional Correctness (major). The gate derived selectors from the pull request head tree while
Stryker mutated the checkout, which is GitHub's merge commit. When main advanced a file the unit
also changed, the two trees disagree on line numbers, so selectors could target the wrong code or
miss the unit's changed lines. The ci command now aligns the working tree to the diff head before
mutation runs, so selection, source reads, and mutation all see one tree. The new test advances a
file on the base, merges, and asserts the tree used for mutation is the unit tree.
2. Functional Correctness (minor). parseStackedMap matched bracket groups and ignored trailing
garbage, so a partially readable map could still select a parent base instead of the event-base
fallback. It now consumes the whole stream of page arrays and returns [] when any part cannot be
parsed.
Also dropped the duplicated comment block above resolveCiInvocation.
Local run: 51 tests pass.1 parent a1a5fe9 commit 9dea54e
2 files changed
Lines changed: 84 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
309 | 309 | | |
310 | 310 | | |
311 | 311 | | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
312 | 325 | | |
313 | 326 | | |
314 | 327 | | |
| |||
837 | 850 | | |
838 | 851 | | |
839 | 852 | | |
840 | | - | |
| 853 | + | |
| 854 | + | |
| 855 | + | |
| 856 | + | |
| 857 | + | |
841 | 858 | | |
842 | | - | |
| 859 | + | |
| 860 | + | |
| 861 | + | |
| 862 | + | |
| 863 | + | |
| 864 | + | |
| 865 | + | |
| 866 | + | |
| 867 | + | |
| 868 | + | |
| 869 | + | |
| 870 | + | |
| 871 | + | |
| 872 | + | |
| 873 | + | |
| 874 | + | |
| 875 | + | |
| 876 | + | |
| 877 | + | |
| 878 | + | |
| 879 | + | |
| 880 | + | |
| 881 | + | |
843 | 882 | | |
844 | 883 | | |
845 | | - | |
| 884 | + | |
846 | 885 | | |
847 | | - | |
| 886 | + | |
848 | 887 | | |
849 | | - | |
| 888 | + | |
850 | 889 | | |
| 890 | + | |
851 | 891 | | |
852 | 892 | | |
853 | 893 | | |
| |||
867 | 907 | | |
868 | 908 | | |
869 | 909 | | |
870 | | - | |
| 910 | + | |
| 911 | + | |
871 | 912 | | |
872 | 913 | | |
873 | 914 | | |
| 915 | + | |
| 916 | + | |
| 917 | + | |
874 | 918 | | |
875 | 919 | | |
876 | 920 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
| |||
353 | 354 | | |
354 | 355 | | |
355 | 356 | | |
356 | | - | |
357 | | - | |
358 | | - | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
359 | 361 | | |
360 | 362 | | |
361 | 363 | | |
| |||
405 | 407 | | |
406 | 408 | | |
407 | 409 | | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
408 | 439 | | |
409 | 440 | | |
410 | 441 | | |
| |||
0 commit comments