Skip to content

Commit 9d1f451

Browse files
committed
feat(settings): dynamic thinking effort experimental toggle (DTE-1)
1 parent ca8a22f commit 9d1f451

34 files changed

Lines changed: 343 additions & 6 deletions
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
import { experimentIds, experimentIdsSchema, experimentsSchema } from "../experiment.js"
2+
3+
describe("dynamicThinkingEffort experiment", () => {
4+
it("is part of the experiment id enum", () => {
5+
expect(experimentIds).toContain("dynamicThinkingEffort")
6+
expect(experimentIdsSchema.safeParse("dynamicThinkingEffort").success).toBe(true)
7+
})
8+
9+
it("parses enabled and disabled states", () => {
10+
expect(experimentsSchema.parse({ dynamicThinkingEffort: true })).toEqual({ dynamicThinkingEffort: true })
11+
expect(experimentsSchema.parse({ dynamicThinkingEffort: false })).toEqual({ dynamicThinkingEffort: false })
12+
expect(experimentsSchema.parse({})).toEqual({})
13+
})
14+
15+
it("rejects non-boolean values", () => {
16+
expect(experimentsSchema.safeParse({ dynamicThinkingEffort: "yes" }).success).toBe(false)
17+
expect(experimentIdsSchema.safeParse("dynamic-thinking-effort").success).toBe(false)
18+
})
19+
})

‎packages/types/src/experiment.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const experimentIds = [
1212
"runSlashCommand",
1313
"customTools",
1414
"parallelToolExecution",
15+
"dynamicThinkingEffort",
1516
] as const
1617

1718
export const experimentIdsSchema = z.enum(experimentIds)
@@ -28,6 +29,7 @@ export const experimentsSchema = z.object({
2829
runSlashCommand: z.boolean().optional(),
2930
customTools: z.boolean().optional(),
3031
parallelToolExecution: z.boolean().optional(),
32+
dynamicThinkingEffort: z.boolean().optional(),
3133
})
3234

3335
export type Experiments = z.infer<typeof experimentsSchema>

‎scripts/stryker-diff.mjs‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,14 @@ export const PACKAGE_CONFIGS = [
5151
root: "src",
5252
sourceRoot: "src/",
5353
vitestConfig: "vitest.config.ts",
54-
vitestRelated: false,
55-
discoverRelatedTests: true,
54+
// Use plugin-side related-test discovery: with an explicit STRYKER_TEST_FILES
55+
// list, stryker-js 10.0.0 plans static mutants with runtime activation
56+
// (stryker-mutator/stryker-js#6144, #6209), which the vitest plugin can only
57+
// apply after top-level code has run, producing false Survived results.
58+
// Revert to vitestRelated: false / discoverRelatedTests: true once the
59+
// upstream planner fix lands.
60+
vitestRelated: true,
61+
discoverRelatedTests: false,
5662
excludedPaths: ["src/esbuild.mjs", "src/eslint.config.mjs", "src/utils/vitest-verbosity.ts"],
5763
},
5864
]

‎scripts/stryker-diff.test.mjs‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,11 @@ describe("buildManifest", () => {
129129
assert.equal(webview.runRoot, ".")
130130
assert.equal(webview.discoverRelatedTests, true)
131131
assert.equal(webview.vitestRelated, false)
132-
assert.equal(extension.discoverRelatedTests, true)
133-
assert.equal(extension.vitestRelated, false)
132+
// The extension entry uses plugin-side related discovery while stryker-js 10.0.0
133+
// plans static mutants with runtime activation when given explicit test files
134+
// (stryker-mutator/stryker-js#6144, #6209); see the entry comment in stryker-diff.mjs.
135+
assert.equal(extension.discoverRelatedTests, false)
136+
assert.equal(extension.vitestRelated, true)
134137
})
135138

136139
it("returns no packages for tests, barrels, unsupported packages, and type-only changes", () => {

‎src/core/webview/__tests__/ClineProvider.spec.ts‎

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1439,6 +1439,38 @@ describe("ClineProvider", () => {
14391439
expect(state.destructiveCommandGuardEnabled).toBe(false)
14401440
})
14411441

1442+
test("getStateToPostToWebview returns the saved dynamicThinkingEffort experiment when enabled", async () => {
1443+
await provider.resolveWebviewView(mockWebviewView)
1444+
await provider.contextProxy.setValue("experiments", {
1445+
...experimentDefault,
1446+
dynamicThinkingEffort: true,
1447+
})
1448+
1449+
const state = await provider.getStateToPostToWebview()
1450+
1451+
expect(state.experiments).toEqual({ ...experimentDefault, dynamicThinkingEffort: true })
1452+
})
1453+
1454+
test("getStateToPostToWebview returns the saved dynamicThinkingEffort experiment when explicitly disabled", async () => {
1455+
await provider.resolveWebviewView(mockWebviewView)
1456+
await provider.contextProxy.setValue("experiments", {
1457+
...experimentDefault,
1458+
dynamicThinkingEffort: false,
1459+
})
1460+
1461+
const state = await provider.getStateToPostToWebview()
1462+
1463+
expect(state.experiments).toEqual({ ...experimentDefault, dynamicThinkingEffort: false })
1464+
})
1465+
1466+
test("getStateToPostToWebview defaults dynamicThinkingEffort to false when experiments are unset", async () => {
1467+
await provider.resolveWebviewView(mockWebviewView)
1468+
1469+
const state = await provider.getStateToPostToWebview()
1470+
1471+
expect(state.experiments).toEqual(experimentDefault)
1472+
})
1473+
14421474
test("language is set to VSCode language", async () => {
14431475
// Mock VSCode language as Spanish
14441476
;(vscode.env as any).language = "pt-BR"

‎src/core/webview/__tests__/webviewMessageHandler.spec.ts‎

Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ import type { ModelRecord } from "@roo-code/types"
7373

7474
import { webviewMessageHandler } from "../webviewMessageHandler"
7575
import type { ClineProvider } from "../ClineProvider"
76+
import { experimentDefault } from "../../../shared/experiments"
7677
import { flushModels, getModels } from "../../../api/providers/fetchers/modelCache"
7778
import { getLMStudioModels } from "../../../api/providers/fetchers/lmstudio"
7879
import { getCommands } from "../../../services/command/commands"
@@ -2273,3 +2274,57 @@ describe("webviewMessageHandler - telemetrySetting", () => {
22732274
expect(TelemetryService.instance.updateTelemetryState).not.toHaveBeenCalled()
22742275
})
22752276
})
2277+
2278+
describe("webviewMessageHandler - experiments", () => {
2279+
beforeEach(() => {
2280+
vi.clearAllMocks()
2281+
})
2282+
2283+
it("persists dynamicThinkingEffort true merged with the saved experiments", async () => {
2284+
vi.mocked(mockClineProvider.contextProxy.getValue).mockImplementation((key: string) =>
2285+
key === "experiments" ? { preventFocusDisruption: true } : undefined,
2286+
)
2287+
2288+
await webviewMessageHandler(mockClineProvider, {
2289+
type: "updateSettings",
2290+
updatedSettings: { experiments: { dynamicThinkingEffort: true } },
2291+
})
2292+
2293+
expect(mockClineProvider.contextProxy.setValue).toHaveBeenCalledWith("experiments", {
2294+
preventFocusDisruption: true,
2295+
dynamicThinkingEffort: true,
2296+
})
2297+
expect(mockClineProvider.postStateToWebview).toHaveBeenCalledTimes(1)
2298+
})
2299+
2300+
it("persists dynamicThinkingEffort false over a previously enabled value", async () => {
2301+
vi.mocked(mockClineProvider.contextProxy.getValue).mockImplementation((key: string) =>
2302+
key === "experiments" ? { dynamicThinkingEffort: true } : undefined,
2303+
)
2304+
2305+
await webviewMessageHandler(mockClineProvider, {
2306+
type: "updateSettings",
2307+
updatedSettings: { experiments: { dynamicThinkingEffort: false } },
2308+
})
2309+
2310+
expect(mockClineProvider.contextProxy.setValue).toHaveBeenCalledWith("experiments", {
2311+
dynamicThinkingEffort: false,
2312+
})
2313+
expect(mockClineProvider.postStateToWebview).toHaveBeenCalledTimes(1)
2314+
})
2315+
2316+
it("persists the experiment defaults when no experiments are saved yet", async () => {
2317+
vi.mocked(mockClineProvider.contextProxy.getValue).mockReturnValue(undefined)
2318+
2319+
await webviewMessageHandler(mockClineProvider, {
2320+
type: "updateSettings",
2321+
updatedSettings: { experiments: {} },
2322+
})
2323+
2324+
expect(mockClineProvider.contextProxy.setValue).toHaveBeenCalledWith("experiments", {
2325+
...experimentDefault,
2326+
dynamicThinkingEffort: false,
2327+
})
2328+
expect(mockClineProvider.postStateToWebview).toHaveBeenCalledTimes(1)
2329+
})
2330+
})

‎src/shared/__tests__/experiments.spec.ts‎

Lines changed: 28 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import type { ExperimentId } from "@roo-code/types"
44

5-
import { EXPERIMENT_IDS, experimentConfigsMap, experiments as Experiments } from "../experiments"
5+
import { EXPERIMENT_IDS, experimentConfigsMap, experimentDefault, experiments as Experiments } from "../experiments"
66

77
describe("experiments", () => {
88
describe("PREVENT_FOCUS_DISRUPTION", () => {
@@ -22,6 +22,7 @@ describe("experiments", () => {
2222
runSlashCommand: false,
2323
customTools: false,
2424
parallelToolExecution: false,
25+
dynamicThinkingEffort: false,
2526
}
2627
expect(Experiments.isEnabled(experiments, EXPERIMENT_IDS.PREVENT_FOCUS_DISRUPTION)).toBe(false)
2728
})
@@ -33,6 +34,7 @@ describe("experiments", () => {
3334
runSlashCommand: false,
3435
customTools: false,
3536
parallelToolExecution: false,
37+
dynamicThinkingEffort: false,
3638
}
3739
expect(Experiments.isEnabled(experiments, EXPERIMENT_IDS.PREVENT_FOCUS_DISRUPTION)).toBe(true)
3840
})
@@ -44,6 +46,7 @@ describe("experiments", () => {
4446
runSlashCommand: false,
4547
customTools: false,
4648
parallelToolExecution: false,
49+
dynamicThinkingEffort: false,
4750
}
4851
expect(Experiments.isEnabled(experiments, EXPERIMENT_IDS.PREVENT_FOCUS_DISRUPTION)).toBe(false)
4952
})
@@ -66,4 +69,28 @@ describe("experiments", () => {
6669
expect(Experiments.isEnabled({ parallelToolExecution: true }, "parallelToolExecution")).toBe(true)
6770
})
6871
})
72+
73+
describe("DYNAMIC_THINKING_EFFORT", () => {
74+
it("is configured correctly", () => {
75+
expect(EXPERIMENT_IDS.DYNAMIC_THINKING_EFFORT).toBe("dynamicThinkingEffort")
76+
expect(experimentConfigsMap.DYNAMIC_THINKING_EFFORT).toMatchObject({
77+
enabled: false,
78+
})
79+
// Visible in the Settings panel (showInSettings defaults to true).
80+
expect(experimentConfigsMap.DYNAMIC_THINKING_EFFORT.showInSettings).toBeUndefined()
81+
})
82+
83+
it("is disabled by default", () => {
84+
expect(experimentDefault.dynamicThinkingEffort).toBe(false)
85+
expect(Experiments.isEnabled({}, "dynamicThinkingEffort")).toBe(false)
86+
})
87+
88+
it("returns true when enabled", () => {
89+
expect(Experiments.isEnabled({ dynamicThinkingEffort: true }, "dynamicThinkingEffort")).toBe(true)
90+
})
91+
92+
it("returns false when explicitly disabled", () => {
93+
expect(Experiments.isEnabled({ dynamicThinkingEffort: false }, "dynamicThinkingEffort")).toBe(false)
94+
})
95+
})
6996
})

‎src/shared/experiments.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ export const EXPERIMENT_IDS = {
66
RUN_SLASH_COMMAND: "runSlashCommand",
77
CUSTOM_TOOLS: "customTools",
88
PARALLEL_TOOL_EXECUTION: "parallelToolExecution",
9+
DYNAMIC_THINKING_EFFORT: "dynamicThinkingEffort",
910
} as const satisfies Record<string, ExperimentId>
1011

1112
type _AssertExperimentIds = AssertEqual<Equals<ExperimentId, Values<typeof EXPERIMENT_IDS>>>
@@ -25,6 +26,7 @@ export const experimentConfigsMap: Record<ExperimentKey, ExperimentConfig> = {
2526
CUSTOM_TOOLS: { enabled: false },
2627
// TODO: add i18n keys (settings:experimental.PARALLEL_TOOL_EXECUTION.name/.description) in the same PR that sets showInSettings: true
2728
PARALLEL_TOOL_EXECUTION: { enabled: false, showInSettings: false },
29+
DYNAMIC_THINKING_EFFORT: { enabled: false },
2830
}
2931

3032
export const experimentDefault = Object.fromEntries(

‎webview-ui/playwright/gallery/stories.tsx‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,11 @@ export const stories: Record<string, Story> = {
162162
const { UISettingsStory } = await import("@/components/settings/__tests__/UISettings.visual.fixture")
163163
return <UISettingsStory />
164164
},
165+
"experimental-settings": async () => {
166+
const { ExperimentalSettingsStory } =
167+
await import("@/components/settings/__tests__/ExperimentalSettings.visual.fixture")
168+
return <ExperimentalSettingsStory />
169+
},
165170
"ui-settings-long-locale": async () => {
166171
const [{ UISettingsStory }, { default: i18next }] = await Promise.all([
167172
import("@/components/settings/__tests__/UISettings.visual.fixture"),

‎webview-ui/src/components/settings/__tests__/ExperimentalSettings.spec.tsx‎

Lines changed: 75 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { render, screen } from "@testing-library/react"
1+
import { fireEvent, render, screen } from "@testing-library/react"
22

33
import { experimentDefault } from "@roo/experiments"
44

@@ -32,4 +32,78 @@ describe("ExperimentalSettings", () => {
3232
expect(screen.getByText("settings:experimental.CUSTOM_TOOLS.name")).toBeInTheDocument()
3333
expect(screen.queryByText("settings:experimental.PARALLEL_TOOL_EXECUTION.name")).not.toBeInTheDocument()
3434
})
35+
36+
it("renders the dynamic thinking effort toggle", () => {
37+
render(<ExperimentalSettings {...defaultProps} />)
38+
39+
expect(screen.getByText("settings:experimental.DYNAMIC_THINKING_EFFORT.name")).toBeInTheDocument()
40+
})
41+
42+
it("leaves the dynamic thinking effort toggle unchecked when the value is false or omitted", () => {
43+
const getCheckbox = () => {
44+
const label = screen.getByText("settings:experimental.DYNAMIC_THINKING_EFFORT.name").closest("label")
45+
return label?.querySelector("input[type='checkbox']")
46+
}
47+
48+
// Explicit false
49+
let result = render(
50+
<ExperimentalSettings
51+
{...defaultProps}
52+
experiments={{ ...experimentDefault, dynamicThinkingEffort: false }}
53+
/>,
54+
)
55+
expect(getCheckbox()).not.toBeNull()
56+
expect(getCheckbox()).not.toBeChecked()
57+
result.unmount()
58+
59+
// Omitted (absent from the persisted config)
60+
const omitted: Record<string, boolean> = { ...experimentDefault }
61+
delete omitted.dynamicThinkingEffort
62+
result = render(<ExperimentalSettings {...defaultProps} experiments={omitted} />)
63+
expect(getCheckbox()).not.toBeNull()
64+
expect(getCheckbox()).not.toBeChecked()
65+
result.unmount()
66+
})
67+
68+
it("binds the dynamic thinking effort toggle to setExperimentEnabled", () => {
69+
const setExperimentEnabled = vi.fn()
70+
render(
71+
<ExperimentalSettings
72+
{...defaultProps}
73+
experiments={{ ...experimentDefault, dynamicThinkingEffort: true }}
74+
setExperimentEnabled={setExperimentEnabled}
75+
/>,
76+
)
77+
78+
const label = screen.getByText("settings:experimental.DYNAMIC_THINKING_EFFORT.name").closest("label")
79+
const checkbox = label?.querySelector("input[type='checkbox']")
80+
expect(checkbox).not.toBeNull()
81+
expect(checkbox).toBeChecked()
82+
83+
fireEvent.click(checkbox!)
84+
85+
expect(setExperimentEnabled).toHaveBeenCalledTimes(1)
86+
expect(setExperimentEnabled).toHaveBeenCalledWith("dynamicThinkingEffort", false)
87+
})
88+
89+
it("toggles the dynamic thinking effort on when clicked from the unchecked state", () => {
90+
const setExperimentEnabled = vi.fn()
91+
render(
92+
<ExperimentalSettings
93+
{...defaultProps}
94+
experiments={{ ...experimentDefault, dynamicThinkingEffort: false }}
95+
setExperimentEnabled={setExperimentEnabled}
96+
/>,
97+
)
98+
99+
const label = screen.getByText("settings:experimental.DYNAMIC_THINKING_EFFORT.name").closest("label")
100+
const checkbox = label?.querySelector("input[type='checkbox']")
101+
expect(checkbox).not.toBeNull()
102+
expect(checkbox).not.toBeChecked()
103+
104+
fireEvent.click(checkbox!)
105+
106+
expect(setExperimentEnabled).toHaveBeenCalledTimes(1)
107+
expect(setExperimentEnabled).toHaveBeenCalledWith("dynamicThinkingEffort", true)
108+
})
35109
})

0 commit comments

Comments
 (0)