@@ -11,7 +11,7 @@ import { ContextProxy } from "../../config/ContextProxy"
1111import { Task } from "../../task/Task"
1212import { ProfileValidator } from "../../../shared/ProfileValidator"
1313import { ClineProvider } from "../ClineProvider"
14- import { generateSessionTitle } from "../../task/session-title"
14+ import { flushPendingSessionTitle , generateSessionTitle } from "../../task/session-title"
1515import * as sessionTitleModule from "../../task/session-title"
1616
1717// Mock setup
@@ -880,6 +880,67 @@ describe("ClineProvider Task History Synchronization", () => {
880880 expect ( getStored ( "task-dispose" ) ?. title ) . toBeUndefined ( )
881881 } )
882882
883+ it ( "waits for a deferred title write before releasing the history store" , async ( ) => {
884+ const taskId = "task-dispose-deferred"
885+ let resolveCompletion ! : ( title : string ) => void
886+ const completion = new Promise < string > ( ( resolve ) => {
887+ resolveCompletion = resolve
888+ } )
889+ const generation = generateSessionTitle ( {
890+ provider,
891+ taskId,
892+ userMessage : "Original prompt" ,
893+ apiConfiguration : {
894+ apiProvider : providerIdentifiers . anthropic ,
895+ apiModelId : "claude-3-5-sonnet-20241022" ,
896+ apiKey : "test-api-key" ,
897+ } ,
898+ completePrompt : async ( ) => completion ,
899+ } )
900+ // The title is generated before the history item exists, so it is deferred.
901+ resolveCompletion ( "Generated Title" )
902+ await generation
903+ await provider . updateTaskHistory ( createHistoryItem ( { id : taskId , task : "Original prompt" } ) , {
904+ broadcast : false ,
905+ } )
906+
907+ // Pause the deferred write inside the store.
908+ let releaseWrite ! : ( ) => void
909+ const writeGate = new Promise < void > ( ( resolve ) => {
910+ releaseWrite = resolve
911+ } )
912+ const originalSetTitle = provider . taskHistoryStore . setTitleIfUnset . bind ( provider . taskHistoryStore )
913+ vi . spyOn ( provider . taskHistoryStore , "setTitleIfUnset" ) . mockImplementation ( async ( id , title ) => {
914+ await writeGate
915+ return originalSetTitle ( id , title )
916+ } )
917+ const storeEvents : string [ ] = [ ]
918+ const originalDispose = provider . taskHistoryStore . dispose . bind ( provider . taskHistoryStore )
919+ vi . spyOn ( provider . taskHistoryStore , "dispose" ) . mockImplementation ( ( ) => {
920+ storeEvents . push ( "store-dispose" )
921+ originalDispose ( )
922+ } )
923+
924+ const flush = flushPendingSessionTitle ( taskId )
925+ await new Promise ( ( resolve ) => setTimeout ( resolve , 10 ) )
926+
927+ // Disposal is held open while the deferred write is still running.
928+ let disposed = false
929+ const disposal = provider . dispose ( ) . then ( ( ) => {
930+ disposed = true
931+ } )
932+ await new Promise ( ( resolve ) => setTimeout ( resolve , 10 ) )
933+ expect ( disposed ) . toBe ( false )
934+ expect ( storeEvents ) . toEqual ( [ ] )
935+
936+ releaseWrite ( )
937+ await flush
938+ await disposal
939+
940+ expect ( storeEvents ) . toEqual ( [ "store-dispose" ] )
941+ expect ( getStored ( taskId ) ?. title ) . toBe ( "Generated Title" )
942+ } )
943+
883944 it ( "cancels pending generation and writes no late title when deleting a task" , async ( ) => {
884945 await provider . updateTaskHistory (
885946 createHistoryItem ( { id : "task-cancel-on-delete" , task : "Original prompt" } ) ,
0 commit comments