You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 94dc7c4
Browse filesBrowse the repository at this point in the historyBrowse files
test(tools): run the guarded-write cancellation rows through Task's own requestAbort
CI's compile arm typechecks the PR merge tree (log line: 'git checkout --force
refs/remotes/pull/1405/merge', 'HEAD is now at 93a83aa Merge 7ea7080 into e487cd7'),
and main took 5319fe9 (#2283, 2026-11-08T16:18:32Z), which makes Task.abort a get-only
accessor fed by the run-state latches. Three rows in this file wrote task.abort directly -
one added here, two pre-existing - so compile turned from success at 90bbdad to failure at
7ea7080 with:
core/tools/__tests__/guardedWrite.spec.ts(549,10): error TS2540: Cannot assign to 'abort'
core/tools/__tests__/guardedWrite.spec.ts(810,8): error TS2540: Cannot assign to 'abort'
core/tools/__tests__/guardedWrite.spec.ts(824,8): error TS2540: Cannot assign to 'abort'
Reproduced locally by checking out the merge tree (git merge-tree --write-tree gives
3b3f02f with no conflicts; tsc --noEmit in that tree printed those same three errors).
The stand-in now sits on Task.prototype with the fields the constructor would have
initialized, so requestAbort is the class's own method and the rows ask production to set the
flag instead of setting it themselves. That works on both spellings: this branch's field write
at Task.ts:3596 and main's latch-fed getter at Task.ts:3582.
Measured: tsc --noEmit at this head 0 errors; eslint --max-warnings=0 on the file 0 messages;
prettier --check clean; guardedWrite.spec.ts 41 passed (41).
0 commit comments