Repository navigation
Commit 94b624c
committed
test(vps2-f2a): cover the launched view and share the settings key lists
- registerCommands.spec: plusButtonClicked gains the isViewLaunched true case. It
counts SidebarProvider.focus executions around the handler rather than asserting
on global history, asserts whenViewResolved was not called, and asserts both
actions are still posted. Control: neutralising the guard at
registerCommands.ts:194 turns the case red. 70 tests to 71.
- webviewMessageHandler: build the two key sets from the exported
GLOBAL_SETTINGS_KEYS and PROVIDER_SETTINGS_KEYS and rename the local global set
to GLOBAL_SETTINGS_KEY_SET, so it no longer shares a name with the shared array.
Measured first with a throwaway probe spec: the exported lists and the schema
shape keys have an empty symmetric difference, and the derived provider-profile
set is identical either way, so this is naming and single source rather than
behaviour - the handler suite is 187 tests before and after. Control: emptying
the provider-profile set fails the host-owned-keys case, so the guard the
refactor keeps is load-bearing.
Gates on this head: src tsc 0, eslint --max-warnings=0 clean on both files,
prettier clean, registerCommands 71 and webviewMessageHandler 187 green.1 parent 8559e8b commit 94b624c
2 files changed
Lines changed: 46 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
900 | 900 | | |
901 | 901 | | |
902 | 902 | | |
| 903 | + | |
| 904 | + | |
| 905 | + | |
| 906 | + | |
| 907 | + | |
| 908 | + | |
| 909 | + | |
| 910 | + | |
| 911 | + | |
| 912 | + | |
| 913 | + | |
| 914 | + | |
| 915 | + | |
| 916 | + | |
| 917 | + | |
| 918 | + | |
| 919 | + | |
| 920 | + | |
| 921 | + | |
| 922 | + | |
| 923 | + | |
| 924 | + | |
| 925 | + | |
| 926 | + | |
| 927 | + | |
| 928 | + | |
| 929 | + | |
| 930 | + | |
| 931 | + | |
| 932 | + | |
| 933 | + | |
| 934 | + | |
| 935 | + | |
| 936 | + | |
| 937 | + | |
| 938 | + | |
| 939 | + | |
| 940 | + | |
| 941 | + | |
| 942 | + | |
| 943 | + | |
903 | 944 | | |
904 | 945 | | |
905 | 946 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
28 | | - | |
| 27 | + | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| |||
126 | 126 | | |
127 | 127 | | |
128 | 128 | | |
129 | | - | |
130 | | - | |
131 | | - | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
| |||
0 commit comments