Repository navigation
Commit 9431c66
Zoo (VP)
fix(telemetry): remove redundant captureException calls that double-count errors
Issue #513 identified captureException sites where the same error is
captured again downstream or where a named telemetry event already
carries the signal:
- Task.ts: captureException(new ConsecutiveMistakeError(...)) fired
right after captureConsecutiveMistakeError(), routing a deliberate
control-flow limit into error tracking as a duplicate.
- presentAssistantMessage.ts: same redundant pairing for the
tool_repetition guard.
- openai-native.ts: handleStreamResponse captured stream-processing
failures and rethrew, after which createMessage's catch captured the
same failure again.
The openrouter handleStreamingError capture was left in place: in
current code its rethrown error is not captured anywhere downstream
(createMessage has no enclosing catch for the stream loop and
completePrompt invokes it outside its try/catch), so removing it would
drop the only capture for mid-stream OpenRouter errors.1 parent bac8adc commit 9431c66
3 files changed
Lines changed: 5 additions & 30 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1129 | 1129 | | |
1130 | 1130 | | |
1131 | 1131 | | |
1132 | | - | |
1133 | | - | |
1134 | | - | |
1135 | | - | |
| 1132 | + | |
| 1133 | + | |
1136 | 1134 | | |
1137 | 1135 | | |
1138 | 1136 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
693 | 693 | | |
694 | 694 | | |
695 | 695 | | |
696 | | - | |
| 696 | + | |
697 | 697 | | |
698 | | - | |
699 | | - | |
700 | | - | |
701 | | - | |
702 | | - | |
703 | | - | |
704 | | - | |
705 | | - | |
706 | | - | |
707 | | - | |
708 | | - | |
709 | 698 | | |
710 | 699 | | |
711 | 700 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
56 | 55 | | |
57 | 56 | | |
58 | 57 | | |
| |||
2998 | 2997 | | |
2999 | 2998 | | |
3000 | 2999 | | |
3001 | | - | |
| 3000 | + | |
3002 | 3001 | | |
3003 | 3002 | | |
3004 | 3003 | | |
3005 | | - | |
3006 | | - | |
3007 | | - | |
3008 | | - | |
3009 | | - | |
3010 | | - | |
3011 | | - | |
3012 | | - | |
3013 | | - | |
3014 | | - | |
3015 | | - | |
3016 | 3004 | | |
3017 | 3005 | | |
3018 | 3006 | | |
| |||
0 commit comments