@@ -36,6 +36,8 @@ vi.mock("vscode", () => ({
3636 } ,
3737 env : {
3838 language : "en" ,
39+ isTelemetryEnabled : true ,
40+ onDidChangeTelemetryEnabled : vi . fn ( ) ,
3941 } ,
4042 ExtensionMode : {
4143 Production : 1 ,
@@ -72,19 +74,19 @@ vi.mock("@roo-code/cloud", () => ({
7274 getRooCodeApiUrl : vi . fn ( ) . mockReturnValue ( "https://app.roocode.com" ) ,
7375} ) )
7476
77+ const mockTelemetryServiceInstance = {
78+ register : vi . fn ( ) ,
79+ setProvider : vi . fn ( ) ,
80+ shutdown : vi . fn ( ) ,
81+ updateTelemetryState : vi . fn ( ) ,
82+ }
83+
7584vi . mock ( "@roo-code/telemetry" , ( ) => ( {
7685 TelemetryService : {
77- createInstance : vi . fn ( ) . mockReturnValue ( {
78- register : vi . fn ( ) ,
79- setProvider : vi . fn ( ) ,
80- shutdown : vi . fn ( ) ,
81- } ) ,
86+ createInstance : vi . fn ( ) . mockReturnValue ( mockTelemetryServiceInstance ) ,
87+ hasInstance : vi . fn ( ) . mockReturnValue ( true ) ,
8288 get instance ( ) {
83- return {
84- register : vi . fn ( ) ,
85- setProvider : vi . fn ( ) ,
86- shutdown : vi . fn ( ) ,
87- }
89+ return mockTelemetryServiceInstance
8890 } ,
8991 } ,
9092 PostHogTelemetryClient : vi . fn ( ) ,
@@ -114,6 +116,7 @@ vi.mock("../core/config/ContextProxy", () => ({
114116 setValue : vi . fn ( ) ,
115117 getValues : vi . fn ( ) . mockReturnValue ( { } ) ,
116118 getProviderSettings : vi . fn ( ) . mockReturnValue ( { } ) ,
119+ getGlobalState : vi . fn ( ) . mockReturnValue ( "enabled" ) ,
117120 } ) ,
118121 } ,
119122} ) )
@@ -286,7 +289,7 @@ describe("extension.ts", () => {
286289 telemetryClient : null ,
287290 authService : null ,
288291 hasActiveSession : vi . fn ( ) . mockReturnValue ( false ) ,
289- } as any
292+ } as unknown as never
290293 } )
291294
292295 vi . mocked ( CloudService . hasInstance ) . mockReturnValue ( true )
@@ -295,7 +298,11 @@ describe("extension.ts", () => {
295298 const { activate } = await import ( "../extension" )
296299 await activate ( mockContext )
297300
298- const provider = ( ClineProvider as any ) . getVisibleInstance ( )
301+ const provider = (
302+ ClineProvider as unknown as {
303+ getVisibleInstance ( ) : { postStateToWebviewWithoutClineMessages : ReturnType < typeof vi . fn > }
304+ }
305+ ) . getVisibleInstance ( )
299306 provider . postStateToWebviewWithoutClineMessages . mockClear ( )
300307
301308 await authStateChangedHandler ! ( {
@@ -317,4 +324,180 @@ describe("extension.ts", () => {
317324 await expect ( activate ( mockContext ) ) . resolves . toBeDefined ( )
318325 } )
319326 } )
327+
328+ describe ( "telemetry level reactivity" , ( ) => {
329+ beforeEach ( async ( ) => {
330+ vi . resetModules ( )
331+ const vscode = await import ( "vscode" )
332+ ; ( vscode . env as { isTelemetryEnabled : boolean } ) . isTelemetryEnabled = true
333+ } )
334+
335+ test ( "registers a listener for vscode.env.onDidChangeTelemetryEnabled" , async ( ) => {
336+ const vscode = await import ( "vscode" )
337+
338+ const { activate } = await import ( "../extension" )
339+ await activate ( mockContext )
340+
341+ expect ( vscode . env . onDidChangeTelemetryEnabled ) . toHaveBeenCalledTimes ( 1 )
342+ expect ( vscode . env . onDidChangeTelemetryEnabled ) . toHaveBeenCalledWith ( expect . any ( Function ) )
343+ } )
344+
345+ test ( "re-evaluates telemetry state from stored settings when VS Code's global toggle changes" , async ( ) => {
346+ const vscode = await import ( "vscode" )
347+ const { TelemetryService } = await import ( "@roo-code/telemetry" )
348+ const { ContextProxy } = await import ( "../core/config/ContextProxy" )
349+
350+ const mockContextProxyInstance = await (
351+ ContextProxy . getInstance as unknown as ( ) => Promise < { getGlobalState : ReturnType < typeof vi . fn > } >
352+ ) ( )
353+ vi . mocked ( mockContextProxyInstance . getGlobalState ) . mockReturnValue ( "enabled" )
354+ ; ( vscode . env as { isTelemetryEnabled : boolean } ) . isTelemetryEnabled = true
355+
356+ const { activate } = await import ( "../extension" )
357+ await activate ( mockContext )
358+
359+ const updateTelemetryStateMock = vi . mocked ( TelemetryService . instance . updateTelemetryState )
360+ updateTelemetryStateMock . mockClear ( )
361+
362+ // The real vscode.env.onDidChangeTelemetryEnabled event carries no payload; the handler
363+ // must read the current vscode.env.isTelemetryEnabled value, not any argument it's called with.
364+ const onDidChangeHandler = vi . mocked ( vscode . env . onDidChangeTelemetryEnabled ) . mock . calls [ 0 ] [ 0 ]
365+ onDidChangeHandler ( undefined as never )
366+
367+ expect ( updateTelemetryStateMock ) . toHaveBeenCalledWith ( true )
368+ } )
369+
370+ test ( "treats a disabled stored setting as opted out even when VS Code telemetry is enabled" , async ( ) => {
371+ const vscode = await import ( "vscode" )
372+ const { TelemetryService } = await import ( "@roo-code/telemetry" )
373+ const { ContextProxy } = await import ( "../core/config/ContextProxy" )
374+
375+ const mockContextProxyInstance = await (
376+ ContextProxy . getInstance as unknown as ( ) => Promise < { getGlobalState : ReturnType < typeof vi . fn > } >
377+ ) ( )
378+ vi . mocked ( mockContextProxyInstance . getGlobalState ) . mockReturnValue ( "disabled" )
379+ ; ( vscode . env as { isTelemetryEnabled : boolean } ) . isTelemetryEnabled = true
380+
381+ const { activate } = await import ( "../extension" )
382+ await activate ( mockContext )
383+
384+ const updateTelemetryStateMock = vi . mocked ( TelemetryService . instance . updateTelemetryState )
385+ updateTelemetryStateMock . mockClear ( )
386+
387+ const onDidChangeHandler = vi . mocked ( vscode . env . onDidChangeTelemetryEnabled ) . mock . calls [ 0 ] [ 0 ]
388+ onDidChangeHandler ( undefined as never )
389+
390+ expect ( updateTelemetryStateMock ) . toHaveBeenCalledWith ( false )
391+ } )
392+
393+ test ( "treats VS Code's live telemetry-disabled signal as opted out even when the stored setting is enabled" , async ( ) => {
394+ const vscode = await import ( "vscode" )
395+ const { TelemetryService } = await import ( "@roo-code/telemetry" )
396+ const { ContextProxy } = await import ( "../core/config/ContextProxy" )
397+
398+ const mockContextProxyInstance = await (
399+ ContextProxy . getInstance as unknown as ( ) => Promise < { getGlobalState : ReturnType < typeof vi . fn > } >
400+ ) ( )
401+ vi . mocked ( mockContextProxyInstance . getGlobalState ) . mockReturnValue ( "enabled" )
402+ ; ( vscode . env as { isTelemetryEnabled : boolean } ) . isTelemetryEnabled = true
403+
404+ const { activate } = await import ( "../extension" )
405+ await activate ( mockContext )
406+
407+ const updateTelemetryStateMock = vi . mocked ( TelemetryService . instance . updateTelemetryState )
408+ updateTelemetryStateMock . mockClear ( )
409+
410+ // Simulate the user turning off VS Code's global telemetry toggle: the live env value
411+ // flips before the event fires, and the handler must honor it rather than only the
412+ // stored extension setting.
413+ ; ( vscode . env as { isTelemetryEnabled : boolean } ) . isTelemetryEnabled = false
414+
415+ const onDidChangeHandler = vi . mocked ( vscode . env . onDidChangeTelemetryEnabled ) . mock . calls [ 0 ] [ 0 ]
416+ onDidChangeHandler ( undefined as never )
417+
418+ expect ( updateTelemetryStateMock ) . toHaveBeenCalledWith ( false )
419+ } )
420+
421+ test ( "pushes a state update to the webview so its own PostHog client picks up the new vscode.env.isTelemetryEnabled value" , async ( ) => {
422+ const vscode = await import ( "vscode" )
423+ const { ClineProvider } = await import ( "../core/webview/ClineProvider" )
424+
425+ const { activate } = await import ( "../extension" )
426+ await activate ( mockContext )
427+
428+ const visibleInstance = (
429+ ClineProvider as unknown as {
430+ getVisibleInstance ( ) : { postStateToWebviewWithoutClineMessages : ReturnType < typeof vi . fn > }
431+ }
432+ ) . getVisibleInstance ( )
433+ vi . mocked ( visibleInstance . postStateToWebviewWithoutClineMessages ) . mockClear ( )
434+
435+ const onDidChangeHandler = vi . mocked ( vscode . env . onDidChangeTelemetryEnabled ) . mock . calls [ 0 ] [ 0 ]
436+ onDidChangeHandler ( undefined as never )
437+
438+ expect ( visibleInstance . postStateToWebviewWithoutClineMessages ) . toHaveBeenCalled ( )
439+ } )
440+ } )
441+
442+ describe ( "deactivate" , ( ) => {
443+ beforeEach ( ( ) => {
444+ vi . resetModules ( )
445+ } )
446+
447+ test ( "still runs terminal cleanup when telemetry shutdown rejects" , async ( ) => {
448+ const { TelemetryService } = await import ( "@roo-code/telemetry" )
449+ const { Terminal } = await import ( "../integrations/terminal/Terminal" )
450+ const { TerminalRegistry } = await import ( "../integrations/terminal/TerminalRegistry" )
451+
452+ vi . mocked ( TelemetryService . instance . shutdown ) . mockRejectedValue ( new Error ( "shutdown failed" ) )
453+ const setTerminalProfileSpy = vi . spyOn ( Terminal , "setTerminalProfile" )
454+
455+ const { activate, deactivate } = await import ( "../extension" )
456+ await activate ( mockContext )
457+
458+ await expect ( deactivate ( ) ) . resolves . toBeUndefined ( )
459+
460+ expect ( setTerminalProfileSpy ) . toHaveBeenCalledWith ( undefined )
461+ expect ( TerminalRegistry . cleanup ) . toHaveBeenCalledTimes ( 1 )
462+
463+ setTerminalProfileSpy . mockRestore ( )
464+ } )
465+
466+ // Review finding: every other TelemetryService call site touched by this PR checks
467+ // hasInstance() first; deactivate()'s shutdown call didn't. Not a crash today (the mock
468+ // always resolves), but TelemetryService.instance throws for real if no instance exists,
469+ // so the guard keeps this call site consistent with the rest of the file.
470+ test ( "does not touch TelemetryService.instance when no instance exists" , async ( ) => {
471+ const { TelemetryService } = await import ( "@roo-code/telemetry" )
472+ const { Terminal } = await import ( "../integrations/terminal/Terminal" )
473+ const { TerminalRegistry } = await import ( "../integrations/terminal/TerminalRegistry" )
474+
475+ const setTerminalProfileSpy = vi . spyOn ( Terminal , "setTerminalProfile" )
476+
477+ const { activate, deactivate } = await import ( "../extension" )
478+ await activate ( mockContext )
479+
480+ // Flip to false only after activate() completes, so this only exercises
481+ // deactivate()'s own guard rather than any hasInstance() check during activation.
482+ vi . mocked ( TelemetryService . hasInstance ) . mockReturnValue ( false )
483+
484+ // Model the real singleton failure mode: TelemetryService.instance throws when no
485+ // instance exists. If deactivate()'s hasInstance() guard were ever removed, this
486+ // throw would surface instead of the assertion below silently passing regardless.
487+ const instanceGetterSpy = vi . spyOn ( TelemetryService , "instance" , "get" ) . mockImplementation ( ( ) => {
488+ throw new Error ( "TelemetryService not initialized" )
489+ } )
490+
491+ await expect ( deactivate ( ) ) . resolves . toBeUndefined ( )
492+
493+ expect ( instanceGetterSpy ) . not . toHaveBeenCalled ( )
494+ expect ( mockTelemetryServiceInstance . shutdown ) . not . toHaveBeenCalled ( )
495+ expect ( setTerminalProfileSpy ) . toHaveBeenCalledWith ( undefined )
496+ expect ( TerminalRegistry . cleanup ) . toHaveBeenCalledTimes ( 1 )
497+
498+ instanceGetterSpy . mockRestore ( )
499+
500+ setTerminalProfileSpy . mockRestore ( )
501+ } )
502+ } )
320503} )
0 commit comments