Repository navigation
Commit 9041eb1
committed
Address review: pin no premature abort before early termination
The early-termination test only observed the request-local signal
after stream.return(), so a premature abort (one landing while the
consumer is still iterating) would also pass. The test now captures
the SDK request options after the first chunk and asserts the
request-local signal is still live (aborted === false) before the
early return, retaining the post-return aborted assertion. Negative
control: aborting the request-local controller right after the SDK
create call fails exactly this test (isolated run: the new false
assertion reddens).
Verification at this head: 27/27 green in lm-studio.spec.ts; tsc
--noEmit 0 errors; eslint --max-warnings=0 clean with suppression
counts unchanged; prettier clean.1 parent f621443 commit 9041eb1
1 file changed
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
467 | 467 | | |
468 | 468 | | |
469 | 469 | | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
470 | 475 | | |
471 | 476 | | |
472 | | - | |
473 | | - | |
| 477 | + | |
474 | 478 | | |
475 | 479 | | |
476 | 480 | | |
| |||
0 commit comments