Skip to content

Commit 8fa009c

Browse files
committed
feat(Task): adding catch block to log any errors
1 parent e57c772 commit 8fa009c

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

‎src/core/task/Task.ts‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1319,8 +1319,9 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
13191319
if (message) {
13201320
this.interactiveAsk = message
13211321
this.emit(RooCodeEventName.TaskInteractive, this.taskId)
1322-
/* v8 ignore next -- fire-and-forget webview notification inside setTimeout; rejection is benign */
1323-
void provider?.postMessageToWebview({ type: "interactionRequired" })
1322+
void provider?.postMessageToWebview({ type: "interactionRequired" }).catch((error) => {
1323+
console.error("[Task#ask] postMessageToWebview interactionRequired failed:", error)
1324+
})
13241325
}
13251326
}, statusMutationTimeout),
13261327
)
@@ -1460,7 +1461,9 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
14601461
)
14611462
if (lastToolAskIndex !== -1) {
14621463
this.clineMessages[lastToolAskIndex].isAnswered = true
1463-
void this.updateClineMessage(this.clineMessages[lastToolAskIndex])
1464+
void this.updateClineMessage(this.clineMessages[lastToolAskIndex]).catch((error) => {
1465+
console.error("[Task#handleWebviewAskResponse] updateClineMessage failed:", error)
1466+
})
14641467
this.saveClineMessages().catch((error) => {
14651468
console.error("Failed to save answered tool-ask state:", error)
14661469
})

‎src/core/task/__tests__/Task.spec.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2368,6 +2368,7 @@ describe("Cline", () => {
23682368

23692369
afterEach(() => {
23702370
consoleErrorSpy.mockRestore()
2371+
vi.restoreAllMocks()
23712372
})
23722373

23732374
it("logs (instead of crashing) when startTask rejects from the constructor", async () => {

0 commit comments

Comments
 (0)