Repository navigation
Commit 8c8db37
committed
fix(file-safety): keep the published target across a post-commit durability error
Port of the U3 commit-state tracking fix to this unit's copies (same
PI row family, identical catch shape):
- safeWriteJson clears the staged path when safeWriteText reports
PostCommitDurabilityError. The rename landed, so the staged path is
the published target's former name; the catch cleanup must not unlink
a path this write no longer owns (a concurrent writer reusing the
staging name would lose its temp file). The durability error rethrows,
so the write is never observed as a confirmed-durable success.
- safeWriteText's failure cleanup only removes the staged temp when the
commit rename never landed (the committed flag it already tracks);
after the commit the staged path names the published target.
Regression test: the parent-directory fsync fails after the commit
rename; safeWriteJson rejects with PostCommitDurabilityError, the target
stays present with the new JSON, and no unlink fires at the consumed
staging path. Negative controls: removing either guard reddens exactly
that test. 80/81 with the file-safety suites (1 pre-existing skip).1 parent 2945ab2 commit 8c8db37
3 files changed
Lines changed: 63 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
477 | 477 | | |
478 | 478 | | |
479 | 479 | | |
480 | | - | |
481 | | - | |
482 | | - | |
483 | | - | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
484 | 490 | | |
485 | 491 | | |
486 | 492 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
441 | 441 | | |
442 | 442 | | |
443 | 443 | | |
444 | | - | |
| 444 | + | |
445 | 445 | | |
446 | 446 | | |
447 | 447 | | |
| |||
463 | 463 | | |
464 | 464 | | |
465 | 465 | | |
466 | | - | |
467 | 466 | | |
468 | 467 | | |
469 | 468 | | |
| |||
702 | 701 | | |
703 | 702 | | |
704 | 703 | | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
705 | 744 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
139 | 140 | | |
140 | 141 | | |
141 | 142 | | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
142 | 153 | | |
143 | 154 | | |
144 | 155 | | |
| |||
0 commit comments