Repository navigation
Commit 836e94a
committed
test: fix describe nesting, strengthen prune assertion, make stale-entry
check deterministic, restore timers in finally
Review round on this unit's test quality: the viewStates describe block was
nested inside the alwaysDenyUnapprovedCommands block, so reported test names
carried the wrong subject; the prune test asserted survival with toDefined(),
which passes even if pruning strips fields - the surviving entries are fully
known, so assert their exact shape (matching the parallel-mode suite); the
stale-temporary-entry test waited on a fixed 10 ms timer, so a slow load
could let the negative assertion pass vacuously - await the load itself;
the readiness-cancel test left fake timers active when an assertion failed
before the restore line, hanging a later real-timer test - restore in a
finally block.
Proofs: global-settings 9/9, ClineProvider.spec 294/294, sticky-mode 33/33,
api-task-control 23/23; negative controls: pruning that strips updatedAt
reddens exactly the prune test, a loadViewState that adopts the unowned
temporary-id entry reddens exactly the stale-entry test, restores
byte-exact (hash match); eslint --max-warnings=0 clean (src and types);
prettier clean.1 parent f78bc04 commit 836e94a
2 files changed
Lines changed: 5 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2084 | 2084 | | |
2085 | 2085 | | |
2086 | 2086 | | |
2087 | | - | |
2088 | | - | |
| 2087 | + | |
| 2088 | + | |
2089 | 2089 | | |
2090 | 2090 | | |
2091 | 2091 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
793 | 793 | | |
794 | 794 | | |
795 | 795 | | |
796 | | - | |
797 | | - | |
| 796 | + | |
| 797 | + | |
| 798 | + | |
798 | 799 | | |
799 | 800 | | |
800 | 801 | | |
| |||
0 commit comments