Repository navigation
Commit 7e649e9
committed
fix(webview): validate the webview-supplied view state id before adopting it
The stable view state id arrives over the webview postMessage channel, so the
declared string type is not a guarantee: a crafted message could carry a
non-string value (which the sanitizer would crash on), an unbounded string
(unbounded growth in the shared viewStates map), or an id another live view
already owns (adopting it would load that view's pinned profile, overlay and
mode here, and let this webview overwrite that view's persisted entry).
setViewStateId now rejects non-strings, bounds the key length, and refuses
ids claimed by another live instance; a refused view stays on its temporary
id and keeps working against the shared state. The spec gains an afterEach
that clears the static instance registry: the suite constructs providers
directly and never disposes most of them, and a leaked instance would
otherwise claim ids ahead of later tests.
Proofs: ClineProvider.sticky-mode.spec 33/33 (3 new tests: non-string,
oversized, claimed-by-another-view); negative controls: disabling the
ownership check reddens exactly the claim test, widening the length bound
reddens exactly the oversized test, restores byte-exact (hash match);
eslint --max-warnings=0 clean; tsc clean except the two known local
telemetry-dist noise lines; prettier ALL-MATCHED on touched files.1 parent 4f60bbf commit 7e649e9
2 files changed
Lines changed: 78 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
216 | 216 | | |
217 | 217 | | |
218 | 218 | | |
| 219 | + | |
219 | 220 | | |
220 | 221 | | |
221 | 222 | | |
| |||
743 | 744 | | |
744 | 745 | | |
745 | 746 | | |
746 | | - | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
747 | 759 | | |
748 | 760 | | |
749 | 761 | | |
| |||
755 | 767 | | |
756 | 768 | | |
757 | 769 | | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
| 773 | + | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
| 779 | + | |
| 780 | + | |
| 781 | + | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
| 786 | + | |
| 787 | + | |
| 788 | + | |
| 789 | + | |
| 790 | + | |
| 791 | + | |
| 792 | + | |
758 | 793 | | |
759 | 794 | | |
760 | 795 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
| 124 | + | |
| 125 | + | |
124 | 126 | | |
125 | 127 | | |
126 | 128 | | |
| |||
221 | 223 | | |
222 | 224 | | |
223 | 225 | | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
224 | 233 | | |
225 | 234 | | |
226 | 235 | | |
| |||
1736 | 1745 | | |
1737 | 1746 | | |
1738 | 1747 | | |
| 1748 | + | |
| 1749 | + | |
| 1750 | + | |
| 1751 | + | |
| 1752 | + | |
| 1753 | + | |
| 1754 | + | |
| 1755 | + | |
| 1756 | + | |
| 1757 | + | |
| 1758 | + | |
| 1759 | + | |
| 1760 | + | |
| 1761 | + | |
| 1762 | + | |
| 1763 | + | |
| 1764 | + | |
| 1765 | + | |
| 1766 | + | |
| 1767 | + | |
| 1768 | + | |
| 1769 | + | |
| 1770 | + | |
| 1771 | + | |
| 1772 | + | |
| 1773 | + | |
| 1774 | + | |
| 1775 | + | |
| 1776 | + | |
| 1777 | + | |
| 1778 | + | |
| 1779 | + | |
| 1780 | + | |
1739 | 1781 | | |
0 commit comments