You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 7750caa
Browse filesBrowse the repository at this point in the historyBrowse files
ci: scope E2E retries to binary download, probe CDN endpoint, prune stale binaries
Address review feedback on #1045:
- Retry only the VS Code binary download (its own step), so genuine
test failures fail fast instead of re-running the whole suite.
- Probe the archive CDN endpoint (via the 302-redirect HEAD) in
addition to the update API, so the stale-binary fallback also
engages when only the CDN host is down.
- Restore/save the binary cache with restore+save actions and prune
older vscode-linux-x64-* dirs so each saved entry keeps one binary
instead of growing with every version bump; skip the save when the
stale fallback was used.
- Emit a ::warning:: when endpoints are unreachable with no cached
binary, and echo why the pass marker is skipped on fallback runs.
# The version-resolution API and the archive CDN are different hosts. The
65
+
# archive URL 302-redirects to the CDN, so a HEAD probe that follows the
66
+
# redirect covers both. The fallback engages when either is unreachable.
64
67
run: |
68
+
API_OK=false
69
+
CDN_OK=false
65
70
if curl -sf --max-time 10 https://update.code.visualstudio.com/api/releases/stable > /dev/null; then
71
+
API_OK=true
72
+
fi
73
+
if curl -sfIL --max-time 20 -o /dev/null "https://update.code.visualstudio.com/${{ steps.vscode-ver.outputs.version }}/linux-x64/stable"; then
74
+
CDN_OK=true
75
+
fi
76
+
if [ "$API_OK" = "true" ] && [ "$CDN_OK" = "true" ]; then
66
77
echo "reachable=true" >> "$GITHUB_OUTPUT"
67
78
else
68
79
echo "reachable=false" >> "$GITHUB_OUTPUT"
80
+
echo "::warning::VS Code download endpoints unreachable (api=$API_OK, cdn=$CDN_OK); will try the stale cached binary"
69
81
fi
70
82
71
83
# @vscode/test-electron only skips its live version-resolution request when the
72
84
# requested version already exists in .vscode-test/. On an exact-key miss it calls
73
85
# the update API before its download retry loop, so an unreachable CDN fails the
74
-
# job before any test runs. When that API is down, point the runner at the stale
75
-
# binary restored above (runTest.ts honors VSCODE_VERSION) so the suite still runs.
86
+
# job before any test runs. When the endpoints are down, point the runner at the
87
+
# stale binary restored above (runTest.ts honors VSCODE_VERSION) so the suite
88
+
# still runs.
76
89
- name: Fall back to stale VS Code binary when CDN is unreachable
0 commit comments