Repository navigation
Commit 7218052
committed
docs(file-safety): state the DACL restore contract the integration case relies on
The comment cited DaclRestoreError and a test name that exist nowhere at this head.
Windows DACL restoration is best-effort after the commit rename: step 5 restores only
once fs.rename has published, _restoreDaclWindows swallows a failing restore, and
the publish resolves - the contract asserted by "win32 DACL: dump is unlinked even
when restore fails" at safeWriteText.spec.ts:829. That is a different contract from
the save side, where a failed icacls /save throws DaclInspectionError phase "save"
before any rename, asserted at safeWriteText.spec.ts:741. Comment only, no behaviour
change and no new test.1 parent 99e4625 commit 7218052
1 file changed
Lines changed: 11 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
32 | 37 | | |
33 | 38 | | |
34 | 39 | | |
| |||
0 commit comments