Repository navigation
Commit 71cfcf3
committed
u1: move the two profile-record declarations to the units that carry their readers
sharedStoreCarriesProfileRecord is called only from the hunk unit 3 carries (1921 head ClineProvider.ts:3840);
ProfileActivationInconsistentError is used only from the hunks unit 2 carries (1921 head :3350 and :4465).
Carrying a declaration whose readers live in another unit leaves it unreachable in the unit that owns it, which
is what made eslint report 2 no-unused-vars problems on this unit, and it is the carrier rule broken in the
opposite direction from the guard test: the guard travelled with its readers, these two did not. Both
declarations move out of this unit and no call site moves to keep a declaration in place. Until unit 3's head
exists on a remote, sharedStoreCarriesProfileRecord exists in no pushed ref, which the unit body and the plan
of record say rather than smooth over.
Hooks: state this plainly. This commit is being made in the campaign scratch worktree where pnpm 10.8.1 is on
PATH and where this round ran check-types and eslint, so husky's pre-commit is able to run; the hook result for
this commit is recorded in the campaign ledger for this round from the commit's own output, not asserted here.
Carrier repairs at unit 1, per the round 58 ruling. The empty broadcastResetToAllInstances header is closed on one line so prettier --check, which the compile context runs, reports the file formatted; the cut that created the two-line form happened here. The module src/core/webview/profileDeletionError.ts no longer travels in unit 1: unit 1 contains no reader of it, and the only reader in #1921 is the import at head 89, which unit 3 carries, so at unit 1's head the file is a new file with no reader, which is what knip --treat-config-hints-as-errors reports as Unused files (1). Its delta moves to unit 3, with the import and the re-export. No behaviour moved, no reading statement changed, no suppression touched.1 parent 836e2e0 commit 71cfcf3
2 files changed
Lines changed: 1 addition & 21 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4554 | 4554 | | |
4555 | 4555 | | |
4556 | 4556 | | |
4557 | | - | |
4558 | | - | |
| 4557 | + | |
4559 | 4558 | | |
4560 | 4559 | | |
4561 | 4560 | | |
| |||
This file was deleted.
0 commit comments