Repository navigation
Commit 6e3cfda
committed
u1: move the two profile-record declarations to the units that carry their readers
sharedStoreCarriesProfileRecord is called only from the hunk unit 3 carries (1921 head ClineProvider.ts:3840);
ProfileActivationInconsistentError is used only from the hunks unit 2 carries (1921 head :3350 and :4465).
Carrying a declaration whose readers live in another unit leaves it unreachable in the unit that owns it, which
is what made eslint report 2 no-unused-vars problems on this unit, and it is the carrier rule broken in the
opposite direction from the guard test: the guard travelled with its readers, these two did not. Both
declarations move out of this unit and no call site moves to keep a declaration in place. Until unit 3's head
exists on a remote, sharedStoreCarriesProfileRecord exists in no pushed ref, which the unit body and the plan
of record say rather than smooth over.
Hooks: state this plainly. This commit is being made in the campaign scratch worktree where pnpm 10.8.1 is on
PATH and where this round ran check-types and eslint, so husky's pre-commit is able to run; the hook result for
this commit is recorded in the campaign ledger for this round from the commit's own output, not asserted here.
Carrier repairs at unit 1, per the round 58 ruling. The empty broadcastResetToAllInstances header is closed on one line so prettier --check, which the compile context runs, reports the file formatted; the cut that created the two-line form happened here. The module src/core/webview/profileDeletionError.ts no longer travels in unit 1: unit 1 contains no reader of it, and the only reader in #1921 is the import at head 89, which unit 3 carries, so at unit 1's head the file is a new file with no reader, which is what knip --treat-config-hints-as-errors reports as Unused files (1). Its delta moves to unit 3, with the import and the re-export. No behaviour moved, no reading statement changed, no suppression touched.
Review dispositions (CodeRabbit row 5849395565 at 836e204-then-71cfcf331411), batched into
this one push rather than four, because dismiss_stale_reviews_on_push is true and every
push after a review row buys another review of the same PR.
- packages/types/src/__tests__/global-settings.test.ts: two describe blocks shared the name
"viewStates global setting" and three of their cases said the same thing. One block now,
with the duplicated reject cases dropped, the key-list assertion and the optional-field
case moved into it, and a null-entry case added so the non-object test covers null as
well as a string. Both blocks were campaign-added by this unit, so no donor line moves.
- src/core/config/ContextProxy.ts:72 and src/core/config/importExport.ts:105: the review
comments and the mutation-diff advisories assert the same thing about the same lines - a
surviving BooleanLiteral mutant at the export omit list, and two surviving mutants at the
import skip - so they are answered here once: a test that export() omits viewStates while
keeping a sibling, and a pair of tests covering the import skip in both directions.
Neither setting had any test in either spec file before this commit.
- src/core/webview/ClineProvider.ts:803: not changed. The compensating restore writes the
comment asks to delete are #1921's own lines at 892, 933, 989 and 1083, and the comment's
own analysis concedes that removing them does not guarantee rollback of the value the
extension host may retain. A split unit does not delete donor production to answer a
minor finding; the reasoning belongs in the thread, not in the diff.
All legs ran under node v25.9.0 with pnpm 10.8.1; the src check-types legs print
Unsupported engine: wanted {"node":"22.23.4"} beside the direct legs, so those legs are
node-25 readings and not the CI interpreter's.1 parent 836e2e0 commit 6e3cfda
5 files changed
Lines changed: 100 additions & 51 deletions
File tree
- packages/types/src/__tests__
- src/core
- config/__tests__
- webview
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | 42 | | |
73 | 43 | | |
74 | 44 | | |
| |||
96 | 66 | | |
97 | 67 | | |
98 | 68 | | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
99 | 81 | | |
100 | 82 | | |
101 | 83 | | |
| |||
145 | 127 | | |
146 | 128 | | |
147 | 129 | | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
148 | 134 | | |
149 | 135 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1170 | 1170 | | |
1171 | 1171 | | |
1172 | 1172 | | |
| 1173 | + | |
| 1174 | + | |
| 1175 | + | |
| 1176 | + | |
| 1177 | + | |
| 1178 | + | |
| 1179 | + | |
| 1180 | + | |
| 1181 | + | |
| 1182 | + | |
| 1183 | + | |
| 1184 | + | |
| 1185 | + | |
| 1186 | + | |
| 1187 | + | |
| 1188 | + | |
| 1189 | + | |
| 1190 | + | |
| 1191 | + | |
| 1192 | + | |
| 1193 | + | |
| 1194 | + | |
| 1195 | + | |
| 1196 | + | |
| 1197 | + | |
| 1198 | + | |
| 1199 | + | |
1173 | 1200 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2806 | 2806 | | |
2807 | 2807 | | |
2808 | 2808 | | |
| 2809 | + | |
| 2810 | + | |
| 2811 | + | |
| 2812 | + | |
| 2813 | + | |
| 2814 | + | |
| 2815 | + | |
| 2816 | + | |
| 2817 | + | |
| 2818 | + | |
| 2819 | + | |
| 2820 | + | |
| 2821 | + | |
| 2822 | + | |
| 2823 | + | |
| 2824 | + | |
| 2825 | + | |
| 2826 | + | |
| 2827 | + | |
| 2828 | + | |
| 2829 | + | |
| 2830 | + | |
| 2831 | + | |
| 2832 | + | |
| 2833 | + | |
| 2834 | + | |
| 2835 | + | |
| 2836 | + | |
| 2837 | + | |
| 2838 | + | |
| 2839 | + | |
| 2840 | + | |
| 2841 | + | |
| 2842 | + | |
| 2843 | + | |
| 2844 | + | |
| 2845 | + | |
| 2846 | + | |
| 2847 | + | |
| 2848 | + | |
| 2849 | + | |
| 2850 | + | |
| 2851 | + | |
| 2852 | + | |
| 2853 | + | |
| 2854 | + | |
| 2855 | + | |
| 2856 | + | |
| 2857 | + | |
| 2858 | + | |
| 2859 | + | |
| 2860 | + | |
| 2861 | + | |
| 2862 | + | |
| 2863 | + | |
| 2864 | + | |
2809 | 2865 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4554 | 4554 | | |
4555 | 4555 | | |
4556 | 4556 | | |
4557 | | - | |
4558 | | - | |
| 4557 | + | |
4559 | 4558 | | |
4560 | 4559 | | |
4561 | 4560 | | |
| |||
This file was deleted.
0 commit comments