Skip to content

Commit 6c27dee

Browse files
docs(dte): describe the effort behaviour instead of the series position
The #1523 review round asked whether comments and test titles that name a series position could describe the behaviour instead, since the position goes stale. This carries that finding onto this unit: the four lines that read DTE series 2/5 now say what the code does (the metadata field is described as the per-request carrier, the two reasoning.ts headers describe the effort envelope and the resolution order, and the spec describe block names the resolver and its precedence). The pointer to resolveEffectiveReasoningEffort stays here, because this unit is the one that defines it (src/api/transform/reasoning.ts); #1523 head 79e1c24 dropped that pointer in its own copy of the same comment block because the resolver does not exist on that branch. Comment and test-title only - no executable line changed (8 diff lines, all comments or one describe title).
1 parent bfe4a09 commit 6c27dee

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎src/api/index.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ export interface ApiHandlerCreateMessageMetadata {
121121
*/
122122
abortSignal?: AbortSignal
123123
/**
124-
* Per-request thinking effort override (DTE series 2/5).
124+
* Per-request thinking effort override, carried in request metadata.
125125
* When defined, takes precedence over the settings-derived `reasoningEffort`
126126
* wherever the effective effort is resolved (see `resolveEffectiveReasoningEffort`).
127127
* Task-scoped and transient: it applies to this request only (the next request

‎src/api/transform/__tests__/dte-effective-reasoning-effort.spec.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import { ADAPTIVE_OUTPUT_CONFIG_EFFORTS, resolveEffectiveReasoningEffort } from "../reasoning"
44

5-
describe("DTE series 2/5 — resolveEffectiveReasoningEffort", () => {
5+
describe("resolveEffectiveReasoningEffort per-request precedence", () => {
66
const settingsEffort = "high"
77
const modelDefault = "medium"
88

‎src/api/transform/reasoning.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export type AnthropicProviderReasoningParams =
3434
export type OpenAiReasoningParams = { reasoning_effort: OpenAI.Chat.ChatCompletionCreateParams["reasoning_effort"] }
3535

3636
/**
37-
* DTE series 2/5 — effort levels accepted by the Claude 4.7+ adaptive-thinking
37+
* Effort levels accepted by the Claude 4.7+ adaptive-thinking
3838
* `output_config.effort` envelope. Efforts outside this set (e.g. "none",
3939
* "minimal", "disable") omit the envelope so the API applies its own default.
4040
* @internal Exported for focused implementation tests.
@@ -48,7 +48,7 @@ export const ADAPTIVE_OUTPUT_CONFIG_EFFORTS: readonly ReasoningEffortExtended[]
4848
]
4949

5050
/**
51-
* DTE series 2/5 — resolves the effective thinking effort for a single request.
51+
* Resolves the effective thinking effort for a single request, strongest override first.
5252
*
5353
* Resolution order (strongest first):
5454
* 1. `override` — the per-request task-local effort

0 commit comments

Comments
 (0)