Repository navigation
Commit 69776b1
committed
fix(tools): keep host paths out of guarded-write rejections (U7, #1375)
The dangling-link rejection interpolated the guard's own absolute ancestor into
model-facing text, while every other rejection in the same file names only the
caller's own spelling. Name the link in the caller's spelling instead, and
assert in the spec that the rejection carries no absolute workspace path.
The queue title spec claimed it renders each queued message's text but asserted
only the heading above the queue, so assert the queued text itself.
Answers review comment 4563093440 (guardedWrite.ts 464-467) and review comment
4568686685 (QueuedMessages.title.spec.tsx 22) on pull 1918.1 parent c83e96c commit 69776b1
3 files changed
Lines changed: 23 additions & 4 deletions
File tree
- src/core/tools
- __tests__
- webview-ui/src/components/chat/__tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
365 | 365 | | |
366 | 366 | | |
367 | 367 | | |
368 | | - | |
369 | | - | |
370 | | - | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
371 | 378 | | |
372 | 379 | | |
373 | 380 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
461 | 461 | | |
462 | 462 | | |
463 | 463 | | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
464 | 473 | | |
465 | | - | |
| 474 | + | |
466 | 475 | | |
467 | 476 | | |
468 | 477 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
23 | 26 | | |
24 | 27 | | |
0 commit comments