Repository navigation
Commit 6160a47
committed
fix(webview): restore the view-local overlays when a setValues write fails
Review follow-up: setValues snapshots the sidebar view local mode/currentApiConfigName overrides (including whether each key was present) before applying a mutation. On failure it restores the shared ContextProxy values and then restores each prior local override through saveViewState, clearing keys that had no override and logging a failed overlay restore without masking the original error. The per-view persistence rollback test now gives the view its own overrides and asserts they survive the failed write. ClineProvider.spec.ts 317 passed; tsc clean.1 parent 4cf697b commit 6160a47
2 files changed
Lines changed: 40 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4632 | 4632 | | |
4633 | 4633 | | |
4634 | 4634 | | |
| 4635 | + | |
| 4636 | + | |
| 4637 | + | |
| 4638 | + | |
| 4639 | + | |
| 4640 | + | |
| 4641 | + | |
| 4642 | + | |
| 4643 | + | |
| 4644 | + | |
| 4645 | + | |
| 4646 | + | |
4635 | 4647 | | |
4636 | 4648 | | |
4637 | 4649 | | |
4638 | 4650 | | |
4639 | 4651 | | |
4640 | 4652 | | |
| 4653 | + | |
| 4654 | + | |
| 4655 | + | |
| 4656 | + | |
| 4657 | + | |
| 4658 | + | |
| 4659 | + | |
| 4660 | + | |
| 4661 | + | |
| 4662 | + | |
| 4663 | + | |
| 4664 | + | |
| 4665 | + | |
| 4666 | + | |
| 4667 | + | |
| 4668 | + | |
| 4669 | + | |
| 4670 | + | |
| 4671 | + | |
| 4672 | + | |
| 4673 | + | |
| 4674 | + | |
4641 | 4675 | | |
4642 | 4676 | | |
4643 | 4677 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2921 | 2921 | | |
2922 | 2922 | | |
2923 | 2923 | | |
| 2924 | + | |
| 2925 | + | |
| 2926 | + | |
| 2927 | + | |
2924 | 2928 | | |
2925 | 2929 | | |
2926 | 2930 | | |
| |||
2934 | 2938 | | |
2935 | 2939 | | |
2936 | 2940 | | |
2937 | | - | |
| 2941 | + | |
| 2942 | + | |
2938 | 2943 | | |
2939 | 2944 | | |
2940 | 2945 | | |
| |||
0 commit comments